From: Michal Kubiak <michal.kubiak@intel.com>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <shenjian15@huawei.com>,
<wangjie125@huawei.com>, <liuyonglong@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 1/3] net: hns3: fix index limit to support all queue stats
Date: Fri, 15 Mar 2024 18:33:58 +0100 [thread overview]
Message-ID: <ZfSGhhn4pkhlZh7G@localhost.localdomain> (raw)
In-Reply-To: <20240315100748.2913882-2-shaojijie@huawei.com>
On Fri, Mar 15, 2024 at 06:07:46PM +0800, Jijie Shao wrote:
> From: Jie Wang <wangjie125@huawei.com>
>
> Currently, hns hardware supports more than 512 queues and the index limit
> in hclge_comm_tqps_update_stats is useless. So this patch remove it.
typo: remove -> removes
>
> Fixes: 287db5c40d15 ("net: hns3: create new set of common tqp stats APIs for PF and VF reuse")
> Signed-off-by: Jie Wang <wangjie125@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
> .../ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c b/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> index f3c9395d8351..618f66d9586b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> @@ -85,7 +85,7 @@ int hclge_comm_tqps_update_stats(struct hnae3_handle *handle,
> hclge_comm_cmd_setup_basic_desc(&desc, HCLGE_OPC_QUERY_TX_STATS,
> true);
>
> - desc.data[0] = cpu_to_le32(tqp->index & 0x1ff);
> + desc.data[0] = cpu_to_le32(tqp->index);
> ret = hclge_comm_cmd_send(hw, &desc, 1);
> if (ret) {
> dev_err(&hw->cmq.csq.pdev->dev,
> --
> 2.30.0
>
>
Thanks,
Michal
next prev parent reply other threads:[~2024-03-15 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 10:07 [PATCH net 0/3] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-03-15 10:07 ` [PATCH net 1/3] net: hns3: fix index limit to support all queue stats Jijie Shao
2024-03-15 17:33 ` Michal Kubiak [this message]
2024-03-15 10:07 ` [PATCH net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization Jijie Shao
2024-03-15 17:48 ` Michal Kubiak
2024-03-15 10:07 ` [PATCH net 3/3] net: hns3: mark unexcuted loopback test result as UNEXECUTED Jijie Shao
2024-03-15 18:07 ` Michal Kubiak
2024-03-16 11:17 ` Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfSGhhn4pkhlZh7G@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox