From: Hangbin Liu <liuhangbin@gmail.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, amcohen@nvidia.com,
petrm@nvidia.com
Subject: Re: [PATCH net] selftests: forwarding: Fix ping failure due to short timeout
Date: Wed, 20 Mar 2024 15:01:34 +0800 [thread overview]
Message-ID: <ZfqJzoIOminBdWCe@Laptop-X1> (raw)
In-Reply-To: <20240320065717.4145325-1-idosch@nvidia.com>
On Wed, Mar 20, 2024 at 08:57:17AM +0200, Ido Schimmel wrote:
> The tests send 100 pings in 0.1 second intervals and force a timeout of
> 11 seconds, which is borderline (especially on debug kernels), resulting
> in random failures in netdev CI [1].
>
> Fix by increasing the timeout to 20 seconds. It should not prolong the
> test unless something is wrong, in which case the test will rightfully
> fail.
>
> [1]
> # selftests: net/forwarding: vxlan_bridge_1d_port_8472_ipv6.sh
> # INFO: Running tests with UDP port 8472
> # TEST: ping: local->local [ OK ]
> # TEST: ping: local->remote 1 [FAIL]
> # Ping failed
> [...]
>
> Fixes: b07e9957f220 ("selftests: forwarding: Add VxLAN tests with a VLAN-unaware bridge for IPv6")
> Fixes: 728b35259e28 ("selftests: forwarding: Add VxLAN tests with a VLAN-aware bridge for IPv6")
> Reported-by: Paolo Abeni <pabeni@redhat.com>
> Closes: https://lore.kernel.org/netdev/24a7051fdcd1f156c3704bca39e4b3c41dfc7c4b.camel@redhat.com/
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
next prev parent reply other threads:[~2024-03-20 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 6:57 [PATCH net] selftests: forwarding: Fix ping failure due to short timeout Ido Schimmel
2024-03-20 7:01 ` Hangbin Liu [this message]
2024-03-20 13:18 ` Jiri Pirko
2024-03-21 11:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfqJzoIOminBdWCe@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).