[PATCH net] selftests: forwarding: Fix ping failure due to short timeout

[PATCH net] selftests: forwarding: Fix ping failure due to short timeout

[Ido Schimmel]

The tests send 100 pings in 0.1 second intervals and force a timeout of
11 seconds, which is borderline (especially on debug kernels), resulting
in random failures in netdev CI [1].

Fix by increasing the timeout to 20 seconds. It should not prolong the
test unless something is wrong, in which case the test will rightfully
fail.

[1]
 # selftests: net/forwarding: vxlan_bridge_1d_port_8472_ipv6.sh
 # INFO: Running tests with UDP port 8472
 # TEST: ping: local->local                                            [ OK ]
 # TEST: ping: local->remote 1                                         [FAIL]
 # Ping failed
 [...]

Fixes: b07e9957f220 ("selftests: forwarding: Add VxLAN tests with a VLAN-unaware bridge for IPv6")
Fixes: 728b35259e28 ("selftests: forwarding: Add VxLAN tests with a VLAN-aware bridge for IPv6")
Reported-by: Paolo Abeni <pabeni@redhat.com>
Closes: https://lore.kernel.org/netdev/24a7051fdcd1f156c3704bca39e4b3c41dfc7c4b.camel@redhat.com/
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 .../testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh  | 4 ++--
 .../testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh b/tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh
index a0bb4524e1e9..a603f7b0a08f 100755
--- a/tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh
+++ b/tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh
@@ -354,7 +354,7 @@ __ping_ipv4()
 
 	# Send 100 packets and verify that at least 100 packets hit the rule,
 	# to overcome ARP noise.
-	PING_COUNT=100 PING_TIMEOUT=11 ping_do $dev $dst_ip
+	PING_COUNT=100 PING_TIMEOUT=20 ping_do $dev $dst_ip
 	check_err $? "Ping failed"
 
 	tc_check_at_least_x_packets "dev $rp1 egress" 101 10 100
@@ -410,7 +410,7 @@ __ping_ipv6()
 
 	# Send 100 packets and verify that at least 100 packets hit the rule,
 	# to overcome neighbor discovery noise.
-	PING_COUNT=100 PING_TIMEOUT=11 ping6_do $dev $dst_ip
+	PING_COUNT=100 PING_TIMEOUT=20 ping6_do $dev $dst_ip
 	check_err $? "Ping failed"
 
 	tc_check_at_least_x_packets "dev $rp1 egress" 101 100
diff --git a/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh b/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh
index d880df89bc8b..e83fde79f40d 100755
--- a/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh
+++ b/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh
@@ -457,7 +457,7 @@ __ping_ipv4()
 
 	# Send 100 packets and verify that at least 100 packets hit the rule,
 	# to overcome ARP noise.
-	PING_COUNT=100 PING_TIMEOUT=11 ping_do $dev $dst_ip
+	PING_COUNT=100 PING_TIMEOUT=20 ping_do $dev $dst_ip
 	check_err $? "Ping failed"
 
 	tc_check_at_least_x_packets "dev $rp1 egress" 101 10 100
@@ -522,7 +522,7 @@ __ping_ipv6()
 
 	# Send 100 packets and verify that at least 100 packets hit the rule,
 	# to overcome neighbor discovery noise.
-	PING_COUNT=100 PING_TIMEOUT=11 ping6_do $dev $dst_ip
+	PING_COUNT=100 PING_TIMEOUT=20 ping6_do $dev $dst_ip
 	check_err $? "Ping failed"
 
 	tc_check_at_least_x_packets "dev $rp1 egress" 101 100
-- 
2.43.0

Re: [PATCH net] selftests: forwarding: Fix ping failure due to short timeout

[Hangbin Liu]

On Wed, Mar 20, 2024 at 08:57:17AM +0200, Ido Schimmel wrote:
> The tests send 100 pings in 0.1 second intervals and force a timeout of
> 11 seconds, which is borderline (especially on debug kernels), resulting
> in random failures in netdev CI [1].
> 
> Fix by increasing the timeout to 20 seconds. It should not prolong the
> test unless something is wrong, in which case the test will rightfully
> fail.
> 
> [1]
>  # selftests: net/forwarding: vxlan_bridge_1d_port_8472_ipv6.sh
>  # INFO: Running tests with UDP port 8472
>  # TEST: ping: local->local                                            [ OK ]
>  # TEST: ping: local->remote 1                                         [FAIL]
>  # Ping failed
>  [...]
> 
> Fixes: b07e9957f220 ("selftests: forwarding: Add VxLAN tests with a VLAN-unaware bridge for IPv6")
> Fixes: 728b35259e28 ("selftests: forwarding: Add VxLAN tests with a VLAN-aware bridge for IPv6")
> Reported-by: Paolo Abeni <pabeni@redhat.com>
> Closes: https://lore.kernel.org/netdev/24a7051fdcd1f156c3704bca39e4b3c41dfc7c4b.camel@redhat.com/
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>

Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>

Re: [PATCH net] selftests: forwarding: Fix ping failure due to short timeout

[Jiri Pirko]

Wed, Mar 20, 2024 at 07:57:17AM CET, idosch@nvidia.com wrote:
>The tests send 100 pings in 0.1 second intervals and force a timeout of
>11 seconds, which is borderline (especially on debug kernels), resulting
>in random failures in netdev CI [1].
>
>Fix by increasing the timeout to 20 seconds. It should not prolong the
>test unless something is wrong, in which case the test will rightfully
>fail.
>
>[1]
> # selftests: net/forwarding: vxlan_bridge_1d_port_8472_ipv6.sh
> # INFO: Running tests with UDP port 8472
> # TEST: ping: local->local                                            [ OK ]
> # TEST: ping: local->remote 1                                         [FAIL]
> # Ping failed
> [...]
>
>Fixes: b07e9957f220 ("selftests: forwarding: Add VxLAN tests with a VLAN-unaware bridge for IPv6")
>Fixes: 728b35259e28 ("selftests: forwarding: Add VxLAN tests with a VLAN-aware bridge for IPv6")
>Reported-by: Paolo Abeni <pabeni@redhat.com>
>Closes: https://lore.kernel.org/netdev/24a7051fdcd1f156c3704bca39e4b3c41dfc7c4b.camel@redhat.com/
>Signed-off-by: Ido Schimmel <idosch@nvidia.com>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Re: [PATCH net] selftests: forwarding: Fix ping failure due to short timeout

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 20 Mar 2024 08:57:17 +0200 you wrote:
> The tests send 100 pings in 0.1 second intervals and force a timeout of
> 11 seconds, which is borderline (especially on debug kernels), resulting
> in random failures in netdev CI [1].
> 
> Fix by increasing the timeout to 20 seconds. It should not prolong the
> test unless something is wrong, in which case the test will rightfully
> fail.
> 
> [...]

Here is the summary with links:
  - [net] selftests: forwarding: Fix ping failure due to short timeout
    https://git.kernel.org/netdev/net/c/e4137851d486

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html