From: Jiri Pirko <jiri@resnulli.us>
To: Duanqiang Wen <duanqiangwen@net-swift.com>
Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com,
mengyuanlou@net-swift.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
maciej.fijalkowski@intel.com, andrew@lunn.ch,
wangxiongfeng2@huawei.com
Subject: Re: [PATCH net] net: txgbe: fix i2c dev name cannot match clkdev
Date: Wed, 20 Mar 2024 14:14:28 +0100 [thread overview]
Message-ID: <ZfrhNFPYjBsMrbbl@nanopsycho> (raw)
In-Reply-To: <20240320032224.326541-1-duanqiangwen@net-swift.com>
Wed, Mar 20, 2024 at 04:22:24AM CET, duanqiangwen@net-swift.com wrote:
>txgbe clkdev shortened clk_name, so i2c_dev info_name
>also need to shorten. Otherwise, i2c_dev cannot initialize
>clock.
>
>Fixes: e30cef001da2 ("net: txgbe: fix clk_name exceed MAX_DEV_ID limits")
>
>Signed-off-by: Duanqiang Wen <duanqiangwen@net-swift.com>
>---
> drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
>index 5b5d5e4310d1..84d04e231b88 100644
>--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
>+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
>@@ -634,7 +634,7 @@ static int txgbe_i2c_register(struct txgbe *txgbe)
>
> info.parent = &pdev->dev;
> info.fwnode = software_node_fwnode(txgbe->nodes.group[SWNODE_I2C]);
>- info.name = "i2c_designware";
>+ info.name = "i2c_dw";
Perhaps this is very good reason to have this string in a define?
> info.id = pci_dev_id(pdev);
>
> info.res = &DEFINE_RES_IRQ(pdev->irq);
>--
>2.27.0
>
>
prev parent reply other threads:[~2024-03-20 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 3:22 [PATCH net] net: txgbe: fix i2c dev name cannot match clkdev Duanqiang Wen
2024-03-20 13:14 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfrhNFPYjBsMrbbl@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).