* [PATCH net] net: txgbe: fix i2c dev name cannot match clkdev
@ 2024-03-20 3:22 Duanqiang Wen
2024-03-20 13:14 ` Jiri Pirko
0 siblings, 1 reply; 2+ messages in thread
From: Duanqiang Wen @ 2024-03-20 3:22 UTC (permalink / raw)
To: netdev, jiawenwu, mengyuanlou, davem, edumazet, kuba, pabeni,
maciej.fijalkowski, andrew, wangxiongfeng2
Cc: Duanqiang Wen
txgbe clkdev shortened clk_name, so i2c_dev info_name
also need to shorten. Otherwise, i2c_dev cannot initialize
clock.
Fixes: e30cef001da2 ("net: txgbe: fix clk_name exceed MAX_DEV_ID limits")
Signed-off-by: Duanqiang Wen <duanqiangwen@net-swift.com>
---
drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
index 5b5d5e4310d1..84d04e231b88 100644
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
@@ -634,7 +634,7 @@ static int txgbe_i2c_register(struct txgbe *txgbe)
info.parent = &pdev->dev;
info.fwnode = software_node_fwnode(txgbe->nodes.group[SWNODE_I2C]);
- info.name = "i2c_designware";
+ info.name = "i2c_dw";
info.id = pci_dev_id(pdev);
info.res = &DEFINE_RES_IRQ(pdev->irq);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net: txgbe: fix i2c dev name cannot match clkdev
2024-03-20 3:22 [PATCH net] net: txgbe: fix i2c dev name cannot match clkdev Duanqiang Wen
@ 2024-03-20 13:14 ` Jiri Pirko
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Pirko @ 2024-03-20 13:14 UTC (permalink / raw)
To: Duanqiang Wen
Cc: netdev, jiawenwu, mengyuanlou, davem, edumazet, kuba, pabeni,
maciej.fijalkowski, andrew, wangxiongfeng2
Wed, Mar 20, 2024 at 04:22:24AM CET, duanqiangwen@net-swift.com wrote:
>txgbe clkdev shortened clk_name, so i2c_dev info_name
>also need to shorten. Otherwise, i2c_dev cannot initialize
>clock.
>
>Fixes: e30cef001da2 ("net: txgbe: fix clk_name exceed MAX_DEV_ID limits")
>
>Signed-off-by: Duanqiang Wen <duanqiangwen@net-swift.com>
>---
> drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
>index 5b5d5e4310d1..84d04e231b88 100644
>--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
>+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
>@@ -634,7 +634,7 @@ static int txgbe_i2c_register(struct txgbe *txgbe)
>
> info.parent = &pdev->dev;
> info.fwnode = software_node_fwnode(txgbe->nodes.group[SWNODE_I2C]);
>- info.name = "i2c_designware";
>+ info.name = "i2c_dw";
Perhaps this is very good reason to have this string in a define?
> info.id = pci_dev_id(pdev);
>
> info.res = &DEFINE_RES_IRQ(pdev->irq);
>--
>2.27.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-20 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-20 3:22 [PATCH net] net: txgbe: fix i2c dev name cannot match clkdev Duanqiang Wen
2024-03-20 13:14 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).