From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B1948C0A for ; Thu, 21 Mar 2024 17:41:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711042898; cv=none; b=rDx+UmtQ5CBZoa8xRn0c7xEha3c13hItze8wgTenS29UfImqRyXXNaFjpKWO1mAtTH+KcU/p8pdT7ZfeG2akhy710/SGrCe9FGIz+awqgkt9YfpM8/AoQyxojeicEICtYSb8q+aTT/w9Etj3RXTcwW58M3kzIfkyj0/VjklFzwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711042898; c=relaxed/simple; bh=Ddafupa7iYOvMi+sXqfxmGGV7rCcvsCabj+hxTgAiD4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P4eH6+Vt56Wwg8Kstz4qdMGBOpWkF5OyHDqtnHUb4thRADahU9ZCbambxJ8FNJPiZm7fLv/mb7V4iASBxg+D76mS7J5fRD9yEk3d8EanCYTr/gH9+83nOtKsz5Fktbg3jLTJPEO2aZzACIQKF24+beTRJbuKgLMpXNgX4rZSBxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org; spf=none smtp.mailfrom=idosch.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Xf79fn3N; arc=none smtp.client-ip=64.147.123.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=idosch.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Xf79fn3N" Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id BF66832000D7; Thu, 21 Mar 2024 13:41:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 21 Mar 2024 13:41:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1711042894; x=1711129294; bh=822J1JVuqbXk+PxzQ6ijlTZ3vZ4t +qgKbmLkE0nki7U=; b=Xf79fn3NQTPgG2ZH8lu1f6ILueo9nFJ50LN0RW2vm546 xQIl3agmcH6jxCu6b6ATBmuHS6zPROApOsAVPF4mi0W6WJiLUT/gTxj08901hH9O 01jVpqOWLT9y5AP0BQYxx1F9VSrIJWhZXVdWsiQmLBhnDHtzHubtOhckNrva4vk3 Amq6jU2g89V1tgw1HNJUdw8WZyOHM9AP7RvXGjBNmTOoEooGFU9WVWfhQtjvlEc5 9WBR+fQZzI6a87XjyilaqrjuzdmpD3gy0GYivx2bcPMB07y1TxGpdZbX2uVC/zIL OlaA411tZjgYa+KT3KXNsSLVY0zvrmsXA82beDECRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrleejgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdortddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpeffueevhffhuddvjeetfeeuudfgheegledvveehheeuueduvdehgedtteefheeg feenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Mar 2024 13:41:32 -0400 (EDT) Date: Thu, 21 Mar 2024 19:41:28 +0200 From: Ido Schimmel To: Eric Dumazet Cc: Gal Pressman , Jakub Kicinski , Stefano Brivio , davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com, jiri@resnulli.us, johannes@sipsolutions.net, fw@strlen.de, pablo@netfilter.org, Martin Pitt , Paul Holzinger , David Gibson Subject: Re: [PATCH net-next v2 3/3] genetlink: fit NLMSG_DONE into same read() as families Message-ID: References: <20240303052408.310064-1-kuba@kernel.org> <20240303052408.310064-4-kuba@kernel.org> <20240315124808.033ff58d@elisabeth> <20240319085545.76445a1e@kernel.org> <20240319104046.203df045@kernel.org> <7e261328-42eb-411d-b1b4-ad884eeaae4d@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 21, 2024 at 06:26:31PM +0100, Eric Dumazet wrote: > The following seems to react quite differently : > > # ip addr show lo > 1: lo: mtu 65536 qdisc noqueue state UNKNOWN > group default qlen 1000 > link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 > inet 127.0.0.1/8 scope host lo > valid_lft forever preferred_lft forever > inet6 ::1/128 scope host proto kernel_lo > valid_lft forever preferred_lft forever > # ip link set dev lo mtu 1000 > # ip addr show lo > 1: lo: mtu 1000 qdisc noqueue state UNKNOWN > group default qlen 1000 > link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 > inet 127.0.0.1/8 scope host lo > valid_lft forever preferred_lft forever Yes, for loopback the NETDEV_CHANGEMTU event is treated as NETDEV_DOWN rather than NETDEV_UNREGISTER: if (dev->mtu < IPV6_MIN_MTU) { addrconf_ifdown(dev, dev != net->loopback_dev); break; } vim net/ipv6/addrconf.c +3656 > Reviewed-by: Eric Dumazet Sorry Eric, already sent the patch without your tag: https://lore.kernel.org/netdev/20240321173042.2151756-1-idosch@nvidia.com/