From: Ido Schimmel <idosch@nvidia.com>
To: Simon Horman <horms@kernel.org>, mail@david-bauer.net
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, amcohen@nvidia.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] vxlan: drop packets from invalid src-address
Date: Wed, 3 Apr 2024 15:45:20 +0300 [thread overview]
Message-ID: <Zg1PYMUh6FCT5FQ2@shredder> (raw)
In-Reply-To: <20240402180848.GT26556@kernel.org>
On Tue, Apr 02, 2024 at 07:08:48PM +0100, Simon Horman wrote:
> On Sun, Mar 31, 2024 at 11:14:34PM +0200, David Bauer wrote:
> > The VXLAN driver currently does not check if the inner layer2
> > source-address is valid.
> >
> > In case source-address snooping/learning is enabled, a entry in the FDB
> > for the invalid address is created with the layer3 address of the tunnel
> > endpoint.
> >
> > If the frame happens to have a non-unicast address set, all this
> > non-unicast traffic is subsequently not flooded to the tunnel network
> > but sent to the learnt host in the FDB. To make matters worse, this FDB
> > entry does not expire.
> >
> > Apply the same filtering for packets as it is done for bridges. This not
> > only drops these invalid packets but avoids them from being learnt into
> > the FDB.
> >
> > Suggested-by: Ido Schimmel <idosch@nvidia.com>
> > Signed-off-by: David Bauer <mail@david-bauer.net>
>
> Hi David and Ido,
>
> I wonder if this is an appropriate candidate for 'net', with a Fixes tag.
> It does seem to address a user-visible problem.
I'm OK with targeting the patch at 'net'. Looking at git history, the
issue seems to be present since initial submission so Fixes tag should
be:
Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
David, can you please re-submit with "[PATCH net]" prefix and the above
tag?
Thanks
next prev parent reply other threads:[~2024-04-03 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 21:14 [PATCH net-next] vxlan: drop packets from invalid src-address David Bauer
2024-04-01 3:04 ` Ratheesh Kannoth
2024-04-01 5:45 ` David Bauer
2024-04-02 18:08 ` Simon Horman
2024-04-03 12:45 ` Ido Schimmel [this message]
2024-04-03 17:14 ` David Bauer
2024-04-04 16:25 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg1PYMUh6FCT5FQ2@shredder \
--to=idosch@nvidia.com \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mail@david-bauer.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).