From: Gregor Herburger <gregor.herburger@ew.tq-group.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dimitri Fedrau <dima.fedrau@gmail.com>,
Stefan Eichenberger <eichest@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@ew.tq-group.com, alexander.stein@ew.tq-group.com
Subject: Re: Re: [PATCH] net: phy: marvell-88q2xxx: add support for Rev B1 and B2
Date: Thu, 4 Apr 2024 16:06:00 +0200 [thread overview]
Message-ID: <Zg6zyJ8gMcwTiSOC@herburgerg-w2> (raw)
In-Reply-To: <Zg1gycEDL4llYrjI@shell.armlinux.org.uk>
Hi Russell,
On Wed, Apr 03, 2024 at 02:59:37PM +0100, Russell King (Oracle) wrote:
> I think a helper would be useful to write these sequences, rather than
> writing the same code several times:
Ok. Will add it to the next version.
>
> static int mv88q2xxx_write_mmd_vals(struct phy_device *phydev,
> const struct mmd_val *vals, size_t len)
> {
> int ret;
>
> for (; len; vals++, len--) {
> ret = phy_write_mmd(phydev, vals->devad, vals->regnum,
> vals->val);
> if (ret < 0)
> return ret;
> }
>
> return 0;
> }
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
prev parent reply other threads:[~2024-04-04 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 13:45 [PATCH] net: phy: marvell-88q2xxx: add support for Rev B1 and B2 Gregor Herburger
2024-04-03 13:59 ` Russell King (Oracle)
2024-04-04 14:06 ` Gregor Herburger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg6zyJ8gMcwTiSOC@herburgerg-w2 \
--to=gregor.herburger@ew.tq-group.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dima.fedrau@gmail.com \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@ew.tq-group.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox