From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Robert Moore" <robert.moore@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Benson Leung" <bleung@chromium.org>,
"Tzung-Bi Shih" <tzungbi@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Thadeu Lima de Souza Cascardo" <cascardo@holoscopio.com>,
"Daniel Oliveira Nascimento" <don@syst.com.br>,
"Pali Rohár" <pali@kernel.org>,
"Matan Ziv-Av" <matan@svgalib.org>,
"Mattia Dongili" <malattia@linux.it>,
"Azael Avalos" <coproscefalo@gmail.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Jeff Sipek" <jsipek@vmware.com>,
"Ajay Kaher" <akaher@vmware.com>,
"Alexey Makhalov" <amakhalov@vmware.com>,
"VMware PV-Drivers Reviewers" <pv-drivers@vmware.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linux.dev, linux-input@vger.kernel.org,
netdev@vger.kernel.org, chrome-platform@lists.linux.dev,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 02/19] Input: atlas: - drop owner assignment
Date: Thu, 28 Mar 2024 10:55:07 -0700 [thread overview]
Message-ID: <ZgWu-33aKyCOjRBX@google.com> (raw)
In-Reply-To: <20240327-b4-module-owner-acpi-v1-2-725241a2d224@linaro.org>
On Wed, Mar 27, 2024 at 08:43:49AM +0100, Krzysztof Kozlowski wrote:
> ACPI bus core already sets the .owner, so driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
But please fix the stray colon in the subject.
>
> ---
>
> Depends on the first patch.
> ---
> drivers/input/misc/atlas_btns.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/atlas_btns.c b/drivers/input/misc/atlas_btns.c
> index 3c9bbd04e143..5b9be2957746 100644
> --- a/drivers/input/misc/atlas_btns.c
> +++ b/drivers/input/misc/atlas_btns.c
> @@ -127,7 +127,6 @@ MODULE_DEVICE_TABLE(acpi, atlas_device_ids);
> static struct acpi_driver atlas_acpi_driver = {
> .name = ACPI_ATLAS_NAME,
> .class = ACPI_ATLAS_CLASS,
> - .owner = THIS_MODULE,
> .ids = atlas_device_ids,
> .ops = {
> .add = atlas_acpi_button_add,
>
> --
> 2.34.1
>
--
Dmitry
next prev parent reply other threads:[~2024-03-28 17:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 7:43 [PATCH 00/19] ACPI: store owner from modules with acpi_bus_register_driver() Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 01/19] " Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 02/19] Input: atlas: - drop owner assignment Krzysztof Kozlowski
2024-03-28 17:55 ` Dmitry Torokhov [this message]
2024-03-28 18:18 ` Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 03/19] net: fjes: " Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 04/19] platform: chrome: " Krzysztof Kozlowski
2024-03-28 10:20 ` Tzung-Bi Shih
2024-03-27 7:43 ` [PATCH 05/19] platform: asus-laptop: " Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 06/19] platform: classmate-laptop: " Krzysztof Kozlowski
2024-03-28 10:24 ` Thadeu Lima de Souza Cascardo
2024-03-27 7:43 ` [PATCH 07/19] platform/x86/dell: " Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 08/19] platform/x86/eeepc: " Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 09/19] platform/x86/intel/rst: " Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 10/19] platform/x86/intel/smartconnect: " Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 11/19] platform/x86/lg-laptop: " Krzysztof Kozlowski
2024-03-27 7:43 ` [PATCH 12/19] platform/x86/sony-laptop: " Krzysztof Kozlowski
2024-03-27 7:44 ` [PATCH 13/19] platform/x86/toshiba_acpi: " Krzysztof Kozlowski
2024-03-27 7:44 ` [PATCH 14/19] platform/x86/toshiba_bluetooth: " Krzysztof Kozlowski
2024-03-27 7:44 ` [PATCH 15/19] platform/x86/toshiba_haps: " Krzysztof Kozlowski
2024-03-27 7:44 ` [PATCH 16/19] platform/x86/wireless-hotkey: " Krzysztof Kozlowski
2024-03-27 7:44 ` [PATCH 17/19] ptp: vmw: " Krzysztof Kozlowski
2024-03-27 7:44 ` [PATCH 18/19] virt: vmgenid: " Krzysztof Kozlowski
2024-03-27 7:44 ` [PATCH 19/19] ACPI: drop redundant owner from acpi_driver Krzysztof Kozlowski
2024-03-27 13:16 ` [PATCH 00/19] ACPI: store owner from modules with acpi_bus_register_driver() Rafael J. Wysocki
2024-03-27 13:30 ` Hans de Goede
2024-03-27 13:32 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgWu-33aKyCOjRBX@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=Jason@zx2c4.com \
--cc=acpica-devel@lists.linux.dev \
--cc=akaher@vmware.com \
--cc=amakhalov@vmware.com \
--cc=bleung@chromium.org \
--cc=cascardo@holoscopio.com \
--cc=chrome-platform@lists.linux.dev \
--cc=coproscefalo@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=davem@davemloft.net \
--cc=don@syst.com.br \
--cc=edumazet@google.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jsipek@vmware.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=malattia@linux.it \
--cc=matan@svgalib.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=richardcochran@gmail.com \
--cc=robert.moore@intel.com \
--cc=tytso@mit.edu \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).