From: Jiri Pirko <jiri@resnulli.us>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCHv4 net-next 1/4] Documentation: netlink: add a YAML spec for team
Date: Tue, 2 Apr 2024 14:22:53 +0200 [thread overview]
Message-ID: <Zgv4nfZzH1mXAByx@nanopsycho> (raw)
In-Reply-To: <20240401031004.1159713-2-liuhangbin@gmail.com>
Mon, Apr 01, 2024 at 05:10:01AM CEST, liuhangbin@gmail.com wrote:
>Add a YAML specification for team.
>
>Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Small note/question below.
[..]
>+ name: attr-option
>+ name-prefix: team-attr-option-
>+ attributes:
>+ -
>+ name: unspec
>+ type: unused
>+ value: 0
>+ -
>+ name: name
>+ type: string
>+ checks:
>+ max-len: string-max-len
>+ unterminated-ok: true
>+ -
>+ name: changed
>+ type: flag
>+ -
>+ name: type
>+ type: u8
>+ -
>+ name: data
>+ type: binary
For the record, this is incomplete as this is not of type "binary" but
rather a type determined by TEAM_ATTR_OPTION_TYPE.
My rejected patch:
https://lore.kernel.org/all/20240219172525.71406-7-jiri@resnulli.us/
Makes that possible to be implemented in ynl.
Jakub, still not willing to pull this in?
[..]
next prev parent reply other threads:[~2024-04-02 12:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 3:10 [PATCHv4 net-next 0/4] doc/netlink: add a YAML spec for team Hangbin Liu
2024-04-01 3:10 ` [PATCHv4 net-next 1/4] Documentation: netlink: " Hangbin Liu
2024-04-02 12:22 ` Jiri Pirko [this message]
2024-04-02 14:45 ` Jakub Kicinski
2024-04-01 3:10 ` [PATCHv4 net-next 2/4] net: team: rename team to team_core for linking Hangbin Liu
2024-04-02 12:23 ` [PATCH net v1] dpll: indent DPLL option type by a tab Jiri Pirko
2024-04-01 3:10 ` [PATCHv4 net-next 3/4] net: team: use policy generated by YAML spec Hangbin Liu
2024-04-02 12:23 ` Jiri Pirko
2024-04-01 3:10 ` [PATCHv4 net-next 4/4] uapi: team: use header file generated from " Hangbin Liu
2024-04-02 12:24 ` Jiri Pirko
2024-04-03 1:40 ` [PATCHv4 net-next 0/4] doc/netlink: add a YAML spec for team patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zgv4nfZzH1mXAByx@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox