From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Marek Behún" <kabel@kernel.org>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Daniel Golle" <daniel@makrotopia.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next 4/6] net: phy: realtek: Change rtlgen_get_speed() to rtlgen_decode_speed()
Date: Tue, 2 Apr 2024 20:27:47 +0100 [thread overview]
Message-ID: <ZgxcM1a7pF1O8iqB@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240402055848.177580-5-ericwouds@gmail.com>
On Tue, Apr 02, 2024 at 07:58:46AM +0200, Eric Woudstra wrote:
> The value of the register to determine the speed, is retrieved
> differently when using Clause 45 only. To use the rtlgen_get_speed()
> function in this case, pass the value of the register as argument to
> rtlgen_get_speed(). The function would then always return 0, so change it
> to void. A better name for this function now is rtlgen_decode_speed().
>
> Replace a call to genphy_read_status() followed by rtlgen_get_speed()
> with a call to rtlgen_read_status() in rtl822x_read_status().
>
> Add reading speed to rtl822x_c45_read_status().
>
> Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-04-02 19:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 5:58 [PATCH v3 net-next 0/6] rtl8226b/8221b add C45 instances and SerDes switching Eric Woudstra
2024-04-02 5:58 ` [PATCH v3 net-next 1/6] net: phy: realtek: configure SerDes mode for rtl822xb PHYs Eric Woudstra
2024-04-02 19:23 ` Russell King (Oracle)
2024-04-02 5:58 ` [PATCH v3 net-next 2/6] net: phy: realtek: add get_rate_matching() " Eric Woudstra
2024-04-02 19:24 ` Russell King (Oracle)
2024-04-02 5:58 ` [PATCH v3 net-next 3/6] net: phy: realtek: Add driver instances for rtl8221b via Clause 45 Eric Woudstra
2024-04-02 19:26 ` Russell King (Oracle)
2024-04-02 5:58 ` [PATCH v3 net-next 4/6] net: phy: realtek: Change rtlgen_get_speed() to rtlgen_decode_speed() Eric Woudstra
2024-04-02 19:27 ` Russell King (Oracle) [this message]
2024-04-02 5:58 ` [PATCH v3 net-next 5/6] net: phy: realtek: add rtl822x_c45_get_features() to set supported ports Eric Woudstra
2024-04-02 15:41 ` Daniel Golle
2024-04-02 18:31 ` Eric Woudstra
2024-04-02 5:58 ` [PATCH v3 net-next 6/6] net: sfp: add quirk for another multigig RollBall transceiver Eric Woudstra
2024-04-02 19:28 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgxcM1a7pF1O8iqB@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=frank-w@public-files.de \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).