From: Louis Peens <louis.peens@corigine.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Fei Qin <fei.qin@corigine.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com
Subject: Re: [PATCH net-next v4 2/4] nfp: update devlink device info output
Date: Tue, 9 Apr 2024 09:31:32 +0200 [thread overview]
Message-ID: <ZhTu1HWnduRMdFoo@LouisNoVo> (raw)
In-Reply-To: <20240408195815.5e932da3@kernel.org>
On Mon, Apr 08, 2024 at 07:58:15PM -0700, Jakub Kicinski wrote:
> On Fri, 5 Apr 2024 10:15:45 +0200 Louis Peens wrote:
> > + * - ``board.part_number``
> > + - fixed
> > + - Part number of the board design
>
> Sorry, one more nit. Part number is not "of the board design"
> Part number is a part number, AFAIU it's a customer-facing
> identifier of a product. Let's drop the design or say "of the
> board and its components"? Since AFAIU part number may also
> change if you replace a component even if you don't have to
> redesign the PCB?
I like "of the board and its components", will update, thanks.
next prev parent reply other threads:[~2024-04-09 7:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 8:15 [PATCH net-next v4 0/4] nfp: series of minor driver improvements Louis Peens
2024-04-05 8:15 ` [PATCH net-next v4 1/4] devlink: add a new info version tag Louis Peens
2024-04-08 13:20 ` Simon Horman
2024-04-05 8:15 ` [PATCH net-next v4 2/4] nfp: update devlink device info output Louis Peens
2024-04-08 13:18 ` Simon Horman
2024-04-09 2:58 ` Jakub Kicinski
2024-04-09 7:31 ` Louis Peens [this message]
2024-04-05 8:15 ` [PATCH net-next v4 3/4] dim: introduce a specific dim profile for better latency Louis Peens
2024-04-08 13:12 ` Simon Horman
2024-04-09 2:55 ` Jakub Kicinski
2024-04-09 7:33 ` Louis Peens
2024-04-05 8:15 ` [PATCH net-next v4 4/4] nfp: use new dim profiles " Louis Peens
2024-04-08 13:13 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhTu1HWnduRMdFoo@LouisNoVo \
--to=louis.peens@corigine.com \
--cc=davem@davemloft.net \
--cc=fei.qin@corigine.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).