From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D57156996; Wed, 10 Apr 2024 10:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712743514; cv=none; b=P8gk/KrrsC/mmeopwUa7QPVym5HpDtBhPmqrio2CsMunzKcN7WPDd5jK2wYHJ0HwV4VV15srV0jVXmNrwAux9icQ8ZkiPYXzd/24CMiWuzu26PfbGMIhagx/g9D4rcffSCXD1e+34vq5K0WgXh+upPxwg+oQJ6PLmn/8gALZotw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712743514; c=relaxed/simple; bh=30woaapoAH8NpTmPC9U/LfaEmvc6WtNWd+ZQ9CZZTGY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nsBM8WC9CEeLq2ZKtuJOuQk/Q39uWPu2fV4iOJ+T9tsMI/dzkywMt0gAEZ1jKYGC7N/ldmoe19sV++3apAu5alzGdR7MRVZBleZQ+PNhK129dbJNs6mGGfaC9CdM/khHi/QMfYxrisiOo9i+3soZ6ozmMKn9xET+5utSLFj3eZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=QwEFMdhw; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="QwEFMdhw" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xGW6DVRYYKhZUWlvDMf+rQo/nW9gpAKrBh3OHMIwwlE=; b=QwEFMdhwMuz0wcDl9wC/hPW66K 07mOUX3JJ0RMXfGCtOeDxYS4j4nIVZBYL2lWPSxsCatpmM9cfqPt3h0CKj9RlOq2zwmzkzRp6fEjJ joJ+91K/2P8ILqnSb+J+Mk2mTzhxRkeoEwIY6nA5EPseC1p1ArJHtG7+x78yWbpA9IYV6JYlsi6wn w6P3j6GrORcbtmYss3I5cFLvJNAOv9YvhTO6XxqCTrmYbZOrskXqk0ATDXr3E5H8dVOS4f/wy7Pc3 noPZPm4VUJKTzsL7/KQmPTr/zpUSfQ720TUIyV0E1i8q+r7uk/+wuWe7VzARQr+HS8JL6V47eaEWk LKcTh93A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45298) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ruUou-0007it-0q; Wed, 10 Apr 2024 11:04:44 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ruUom-0005tk-D4; Wed, 10 Apr 2024 11:04:36 +0100 Date: Wed, 10 Apr 2024 11:04:36 +0100 From: "Russell King (Oracle)" To: Kory Maincent Cc: Jakub Kicinski , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier , Rahul Rameshbabu , Alexandra Winter Subject: Re: [PATCH net-next v10 07/13] net: Add struct kernel_ethtool_ts_info Message-ID: References: <20240409-feature_ptp_netnext-v10-0-0fa2ea5c89a9@bootlin.com> <20240409-feature_ptp_netnext-v10-7-0fa2ea5c89a9@bootlin.com> <20240409182725.139856d5@kernel.org> <20240410101200.0178e594@kmaincent-XPS-13-7390> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240410101200.0178e594@kmaincent-XPS-13-7390> Sender: Russell King (Oracle) On Wed, Apr 10, 2024 at 10:12:00AM +0200, Kory Maincent wrote: > On Tue, 9 Apr 2024 18:27:25 -0700 > Jakub Kicinski wrote: > > > On Tue, 09 Apr 2024 10:26:29 +0200 Kory Maincent wrote: > > > In prevision to add new UAPI for hwtstamp we will be limited to the struct > > > ethtool_ts_info that is currently passed in fixed binary format through the > > > ETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new kernel code > > > already started operating on an extensible kernel variant of that > > > structure, similar in concept to struct kernel_hwtstamp_config vs struct > > > hwtstamp_config. > > > > > > Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, here > > > we introduce the kernel-only structure in include/linux/ethtool.h. > > > The manual copy is then made in the function called by ETHTOOL_GET_TS_INFO. > > > > > > > This one now conflicts :( > > > > Applying: net: Add struct kernel_ethtool_ts_info > > error: sha1 information is lacking or useless (drivers/net/phy/marvell_ptp.c). > > error: could not build fake ancestor > > gnn patching my out of tree patch in the series! Sorry for that. Given that this path corresponds to the driver I wrote, do I assume that you've picked up my work on PTP support for Marvell PHYs? You should be aware that I still have the patches out of tree but it's been pointless me reposting it until the issue of which PTP gets used has been solved. (Publishing will just increase the pressure to merge it without the PTP problems being solved, and thus break Marvell PP2 PTP.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!