netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Louis Peens <louis.peens@corigine.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jiri Pirko <jiri@resnulli.us>, Fei Qin <fei.qin@corigine.com>,
	netdev@vger.kernel.org, oss-drivers@corigine.com
Subject: Re: [PATCH net-next v5 2/2] nfp: update devlink device info output
Date: Thu, 11 Apr 2024 08:18:46 +0200	[thread overview]
Message-ID: <ZheAxsfnbF0lBK9Q@LouisNoVo> (raw)
In-Reply-To: <fdfecdb3-2070-40d9-8129-01df41d4232f@intel.com>

On Wed, Apr 10, 2024 at 03:27:22PM -0700, Jacob Keller wrote:
> 
> 
> On 4/10/2024 4:26 AM, Louis Peens wrote:
> > From: Fei Qin <fei.qin@corigine.com>
> > 
> > Newer NIC will introduce a new part number, now add it
> > into devlink device info.
> > 
> > This patch also updates the information of "board.id" in
> > nfp.rst to match the devlink-info.rst.
> > 
> 
> I was a bit confused since you didn't update the board.id to reference
> something else. I am guessing in newer images, the "assembly.partno"
> would be different from "pn"?

Hi - yes, they would be two different things, approximate example for
new images:
    board.id ~ AMDA2001-1003
    board.part_number ~ CGX11-A2PSNM

Old images will just have board.id. The field naming we get from the
hardware is indeed slightly confusing, but since they are used
differently we could not just update board.id.

I hope this clears things up.

Regards
Louis
> 
> Thanks,
> Jake

  reply	other threads:[~2024-04-11  6:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 11:26 [PATCH net-next v5 0/2] nfp: series of minor driver improvements Louis Peens
2024-04-10 11:26 ` [PATCH net-next v5 1/2] devlink: add a new info version tag Louis Peens
2024-04-10 11:26 ` [PATCH net-next v5 2/2] nfp: update devlink device info output Louis Peens
2024-04-10 22:27   ` Jacob Keller
2024-04-11  6:18     ` Louis Peens [this message]
2024-04-11 16:10       ` Keller, Jacob E
2024-04-12 10:50 ` [PATCH net-next v5 0/2] nfp: series of minor driver improvements patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZheAxsfnbF0lBK9Q@LouisNoVo \
    --to=louis.peens@corigine.com \
    --cc=davem@davemloft.net \
    --cc=fei.qin@corigine.com \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).