[PATCH net-next v5 0/2] nfp: series of minor driver improvements

[PATCH net-next v5 0/2] nfp: series of minor driver improvements

[Louis Peens]

This short series bundles now only includes a small update to add a
board part number to devlink. Previously some dim patches also formed
part of this series, these were dropped in v5.

Patch1: Add new define for devlink string "board.part_number"
Patch2: Make use of this field in the nfp driver

Changes since V4:
- Dropped the dim patches, as there is a more significant rework in
  progress to make it more flexible, as mentioned in the V4 review:
  https://lore.kernel.org/all/1712547870-112976-2-git-send-email-hengqi@linux.alibaba.com/
- Updated the devlink description of 'board.part_number'

Changes since V3:
- Fixed: Documentation/networking/devlink/devlink-info.rst:150:
    WARNING: Title underline too short.

Changes since V2:
- After some discussion on the previous series it was agreed that only
  the "board.part_number" field makes sense in the common code. The
  "board.model" field which was moved to devlink common code in V1 is
  now kept in the driver. The field is specific to the nfp driver,
  exposing the codename of the board.
- In summary, add "board.part_number" to devlink, and populate it
  in the the nfp driver.

Changes since V1:
- Move nfp local defines to devlink common code as it is quite generic.
- Add new 'dim' profile instead of using driver local overrides, as this
  allows use of the 'dim' helpers.
- This expanded 2 patches to 4, as the common code changes are split
  into seperate patches.

Fei Qin (2):
  devlink: add a new info version tag
  nfp: update devlink device info output

 Documentation/networking/devlink/devlink-info.rst | 5 +++++
 Documentation/networking/devlink/nfp.rst          | 5 ++++-
 drivers/net/ethernet/netronome/nfp/nfp_devlink.c  | 1 +
 include/net/devlink.h                             | 4 +++-
 4 files changed, 13 insertions(+), 2 deletions(-)

-- 
2.34.1

[PATCH net-next v5 1/2] devlink: add a new info version tag

[Louis Peens]

From: Fei Qin <fei.qin@corigine.com>

Add definition and documentation for the new generic
info "board.part_number".

The new one is for part number specific use, and board.id
is modified to match the documentation in devlink-info.

Signed-off-by: Fei Qin <fei.qin@corigine.com>
Signed-off-by: Louis Peens <louis.peens@corigine.com>
---
 Documentation/networking/devlink/devlink-info.rst | 5 +++++
 include/net/devlink.h                             | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
index 1242b0e6826b..23073bc219d8 100644
--- a/Documentation/networking/devlink/devlink-info.rst
+++ b/Documentation/networking/devlink/devlink-info.rst
@@ -146,6 +146,11 @@ board.manufacture
 
 An identifier of the company or the facility which produced the part.
 
+board.part_number
+-----------------
+
+Part number of the board and its components.
+
 fw
 --
 
diff --git a/include/net/devlink.h b/include/net/devlink.h
index bb1af599d101..d31769a116ce 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -599,12 +599,14 @@ enum devlink_param_generic_id {
 	.validate = _validate,						\
 }
 
-/* Part number, identifier of board design */
+/* Identifier of board design */
 #define DEVLINK_INFO_VERSION_GENERIC_BOARD_ID	"board.id"
 /* Revision of board design */
 #define DEVLINK_INFO_VERSION_GENERIC_BOARD_REV	"board.rev"
 /* Maker of the board */
 #define DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE	"board.manufacture"
+/* Part number of the board and its components */
+#define DEVLINK_INFO_VERSION_GENERIC_BOARD_PART_NUMBER	"board.part_number"
 
 /* Part number, identifier of asic design */
 #define DEVLINK_INFO_VERSION_GENERIC_ASIC_ID	"asic.id"
-- 
2.34.1

[PATCH net-next v5 2/2] nfp: update devlink device info output

[Louis Peens]

From: Fei Qin <fei.qin@corigine.com>

Newer NIC will introduce a new part number, now add it
into devlink device info.

This patch also updates the information of "board.id" in
nfp.rst to match the devlink-info.rst.

Signed-off-by: Fei Qin <fei.qin@corigine.com>
Signed-off-by: Louis Peens <louis.peens@corigine.com>
---
 Documentation/networking/devlink/nfp.rst         | 5 ++++-
 drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 1 +
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/networking/devlink/nfp.rst b/Documentation/networking/devlink/nfp.rst
index a1717db0dfcc..3093642bdae4 100644
--- a/Documentation/networking/devlink/nfp.rst
+++ b/Documentation/networking/devlink/nfp.rst
@@ -32,7 +32,7 @@ The ``nfp`` driver reports the following versions
      - Description
    * - ``board.id``
      - fixed
-     - Part number identifying the board design
+     - Identifier of the board design
    * - ``board.rev``
      - fixed
      - Revision of the board design
@@ -42,6 +42,9 @@ The ``nfp`` driver reports the following versions
    * - ``board.model``
      - fixed
      - Model name of the board design
+   * - ``board.part_number``
+     - fixed
+     - Part number of the board and its components
    * - ``fw.bundle_id``
      - stored, running
      - Firmware bundle id
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
index 635d33c0d6d3..ea75b9a06313 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
@@ -160,6 +160,7 @@ static const struct nfp_devlink_versions_simple {
 	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_REV,	"assembly.revision", },
 	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE, "assembly.vendor", },
 	{ "board.model", /* code name */		"assembly.model", },
+	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_PART_NUMBER, "pn", },
 };
 
 static int
-- 
2.34.1

Re: [PATCH net-next v5 2/2] nfp: update devlink device info output

[Jacob Keller]

On 4/10/2024 4:26 AM, Louis Peens wrote:
> From: Fei Qin <fei.qin@corigine.com>
> 
> Newer NIC will introduce a new part number, now add it
> into devlink device info.
> 
> This patch also updates the information of "board.id" in
> nfp.rst to match the devlink-info.rst.
> 

I was a bit confused since you didn't update the board.id to reference
something else. I am guessing in newer images, the "assembly.partno"
would be different from "pn"?

Thanks,
Jake

Re: [PATCH net-next v5 2/2] nfp: update devlink device info output

[Louis Peens]

On Wed, Apr 10, 2024 at 03:27:22PM -0700, Jacob Keller wrote:
> 
> 
> On 4/10/2024 4:26 AM, Louis Peens wrote:
> > From: Fei Qin <fei.qin@corigine.com>
> > 
> > Newer NIC will introduce a new part number, now add it
> > into devlink device info.
> > 
> > This patch also updates the information of "board.id" in
> > nfp.rst to match the devlink-info.rst.
> > 
> 
> I was a bit confused since you didn't update the board.id to reference
> something else. I am guessing in newer images, the "assembly.partno"
> would be different from "pn"?

Hi - yes, they would be two different things, approximate example for
new images:
    board.id ~ AMDA2001-1003
    board.part_number ~ CGX11-A2PSNM

Old images will just have board.id. The field naming we get from the
hardware is indeed slightly confusing, but since they are used
differently we could not just update board.id.

I hope this clears things up.

Regards
Louis
> 
> Thanks,
> Jake

RE: [PATCH net-next v5 2/2] nfp: update devlink device info output

[Keller, Jacob E]

> -----Original Message-----
> From: Louis Peens <louis.peens@corigine.com>
> Sent: Wednesday, April 10, 2024 11:19 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: David Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Jiri Pirko <jiri@resnulli.us>; Fei Qin
> <fei.qin@corigine.com>; netdev@vger.kernel.org; oss-drivers@corigine.com
> Subject: Re: [PATCH net-next v5 2/2] nfp: update devlink device info output
> 
> On Wed, Apr 10, 2024 at 03:27:22PM -0700, Jacob Keller wrote:
> >
> >
> > On 4/10/2024 4:26 AM, Louis Peens wrote:
> > > From: Fei Qin <fei.qin@corigine.com>
> > >
> > > Newer NIC will introduce a new part number, now add it
> > > into devlink device info.
> > >
> > > This patch also updates the information of "board.id" in
> > > nfp.rst to match the devlink-info.rst.
> > >
> >
> > I was a bit confused since you didn't update the board.id to reference
> > something else. I am guessing in newer images, the "assembly.partno"
> > would be different from "pn"?
> 
> Hi - yes, they would be two different things, approximate example for
> new images:
>     board.id ~ AMDA2001-1003
>     board.part_number ~ CGX11-A2PSNM
> 
> Old images will just have board.id. The field naming we get from the
> hardware is indeed slightly confusing, but since they are used
> differently we could not just update board.id.
> 
> I hope this clears things up.
> 

Yes, thanks! It might be helpful to include examples of actual values in the doc.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> Regards
> Louis
> >
> > Thanks,
> > Jake

Re: [PATCH net-next v5 0/2] nfp: series of minor driver improvements

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Wed, 10 Apr 2024 13:26:34 +0200 you wrote:
> This short series bundles now only includes a small update to add a
> board part number to devlink. Previously some dim patches also formed
> part of this series, these were dropped in v5.
> 
> Patch1: Add new define for devlink string "board.part_number"
> Patch2: Make use of this field in the nfp driver
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/2] devlink: add a new info version tag
    https://git.kernel.org/netdev/net-next/c/3bb946c9d323
  - [net-next,v5,2/2] nfp: update devlink device info output
    https://git.kernel.org/netdev/net-next/c/8910f93b9570

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html