From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C424513CA9C for ; Thu, 11 Apr 2024 06:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712816622; cv=none; b=tIl8O4yaLXq+HYdR679dXMYpTkVBDTNNIE9kttLtuor8cNgcuzozg/7SGckpw3FaJEyQv82Jxt3DRnDD8J9AGZfv+apfKIFu6NpOkaTBVTf8s7VbcYSHppyRpUf/6VhDZtGT1EAajU2FL5PTnTd6UQ3DlHfTf9TwVN9Brl3Q1D0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712816622; c=relaxed/simple; bh=pTWLQpW9RVU2IjRukXzUGYvxyE+olS3ZH5i76ahO8P4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mg2pVJWc7D16iF6sCLbs1z/dsbNrsQjZms+44FCg1DehUIFJpMBicu7h0/rnenU3NBhhfcorhNj45RETNkTC0a5mOhEHtmDB0brtJ3pJSkksYBMCInggYK4Rj8HOYQrRiFaK6JkjVVm+Z96vvtalX+zrYJNWP1eI6jT+jG6Gtk0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=T6mAtzEW; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="T6mAtzEW" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d8b194341eso23755711fa.3 for ; Wed, 10 Apr 2024 23:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1712816617; x=1713421417; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5lZTFJACV3+JbwVwRwvE8FlPJbh+9wi0aUKAYU88cAc=; b=T6mAtzEWsvSFJVelBAO7GMLtShyCwYgw93Sd4XzMlA7pTPehBzOzvgGmGoujqOsfaY DcXLdd5Xp/rVL0SfK2aJjjtyxFFXDkV/77t6VqrpFXzgQ9lgkE0Czj18Mh1Ky+lsMHaC Ps03teF3bWvkeoWB6c5dzJVHbif5V5xg9i3b+v+EJUcKIo8f1bKQMAoeqFT8Gs16hT43 6aqQIsmm3I5/fV1PnSMWFV3d0SUVeU9fKcCsr4/DEGl4EyebTqInsDJC8xIpVuvkb4PX QTkx7ppU71r8Z/zTyl+TP6tcEsyvIZgzm9lfcJ/ANh0jAVg5ZbzOT2cSe1JCGJ/udZKJ 1Yvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712816617; x=1713421417; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5lZTFJACV3+JbwVwRwvE8FlPJbh+9wi0aUKAYU88cAc=; b=DEYa0YraLbrJi1t8MlajA57igW78ebuTKeECnZJpx+TUONjPTfcry+PJIVaqlkBA3P wIeZcM0QN1j/8yo2snlvSwpZLRsHtcPC2xv2FAIULwZ9kL+fzF0WFSNd3bI/vQaYSOEV e9OpaF63mbZ5OglpvzXlXoJKAz4sPBXpGM2GmGVXqi04K+N4lLzs8kaO71SR2z/0Vp7g 8dDPX9GXF9eEFHqh7ZvrcDJyaGCOgF08vw2oYl9KDE1Vt93HqtlqfLkZfUWrQ4Uq/pY6 /g/3x8GYxpVmMWq1887sK09799ZiZ1x1tT7GpEX8JFo9+V+IBqpXC0aFOExeczMb3kBf DyFw== X-Forwarded-Encrypted: i=1; AJvYcCUzLqLAe+IATtYW6DPdl02ThZCFiXRiKe6BkzqW4NHCM6MBB0pYOiPp5GHbtpKDcuoA8o5rDANrsyeNhMn/CvDF8VXZs7LF X-Gm-Message-State: AOJu0YwQeHoArcKYMyzQ42rc09ioRPg78UjgfqN/rE0ArwCFJjmD8K+5 MkdNXjmXQNeKNaXnZCDCxVDx0a4p8Tp2/7H2jwF1eJOjc0UfweHl+5b8kpRyIHQ= X-Google-Smtp-Source: AGHT+IFkIcdj47hwnqrwRBDPoFbtpCm6hEqmTe7HSx9TotuKs4UPXIr2bhVJ1LAxUHsvGfGv5Jcuqg== X-Received: by 2002:a2e:a413:0:b0:2d6:a5f6:c8d3 with SMTP id p19-20020a2ea413000000b002d6a5f6c8d3mr2822772ljn.27.1712816617380; Wed, 10 Apr 2024 23:23:37 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id n39-20020a05600c502700b00417e3695371sm70793wmr.33.2024.04.10.23.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 23:23:36 -0700 (PDT) Date: Thu, 11 Apr 2024 08:23:35 +0200 From: Jiri Pirko To: Jijie Shao Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, rkannoth@marvell.com, shenjian15@huawei.com, wangjie125@huawei.com, liuyonglong@huawei.com, chenhao418@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V7 net-next 4/4] net: hns3: add support to query scc version by devlink info Message-ID: References: <20240410125354.2177067-1-shaojijie@huawei.com> <20240410125354.2177067-5-shaojijie@huawei.com> <16347737-f0ac-4710-85ee-189abed59d6b@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16347737-f0ac-4710-85ee-189abed59d6b@huawei.com> Thu, Apr 11, 2024 at 03:05:53AM CEST, shaojijie@huawei.com wrote: > >on 2024/4/10 22:59, Jiri Pirko wrote: >> Wed, Apr 10, 2024 at 02:53:54PM CEST, shaojijie@huawei.com wrote: >> > From: Hao Chen >> > >> > Add support to query scc version by devlink info for device V3. >> > >> > Signed-off-by: Hao Chen >> > Signed-off-by: Jijie Shao >> > --- >> > Documentation/networking/devlink/hns3.rst | 3 ++ >> > drivers/net/ethernet/hisilicon/hns3/hnae3.h | 9 ++++ >> > .../hns3/hns3_common/hclge_comm_cmd.h | 8 ++++ >> > .../hisilicon/hns3/hns3pf/hclge_devlink.c | 44 +++++++++++++++++-- >> > .../hisilicon/hns3/hns3pf/hclge_devlink.h | 2 + >> > .../hisilicon/hns3/hns3pf/hclge_main.c | 18 ++++++++ >> > .../hisilicon/hns3/hns3pf/hclge_main.h | 1 + >> > 7 files changed, 82 insertions(+), 3 deletions(-) >> > >> > diff --git a/Documentation/networking/devlink/hns3.rst b/Documentation/networking/devlink/hns3.rst >> > index 4562a6e4782f..e19dea8ef924 100644 >> > --- a/Documentation/networking/devlink/hns3.rst >> > +++ b/Documentation/networking/devlink/hns3.rst >> > @@ -23,3 +23,6 @@ The ``hns3`` driver reports the following versions >> > * - ``fw`` >> > - running >> > - Used to represent the firmware version. >> > + * - ``fw.scc`` >> What's scc? I don't see it described anywhere. > >diff --git a/Documentation/networking/devlink/hns3.rst b/Documentation/networking/devlink/hns3.rst >index 4562a6e4782f..e19dea8ef924 100644 >--- a/Documentation/networking/devlink/hns3.rst >+++ b/Documentation/networking/devlink/hns3.rst >@@ -23,3 +23,6 @@ The ``hns3`` driver reports the following versions > * - ``fw`` > - running > - Used to represent the firmware version. >+ * - ``fw.scc`` >+ - running >+ - Used to represent the soft congestion control firmware version. > >scc means "soft congestion control" I guess this is something specific to your device, isn't it? Can't you please extend the description a bit more? Thanks! >