From: Louis Peens <louis.peens@corigine.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, Yanguo Li <yanguo.li@corigine.com>,
oss-drivers@corigine.com,
Taras Chornyi <taras.chornyi@plvision.eu>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Edward Cree <ecree.xilinx@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next v2 2/4] nfp: flower: fix check for unsupported control flags
Date: Thu, 11 Apr 2024 08:59:25 +0200 [thread overview]
Message-ID: <ZheKTadCKyX23U0k@LouisNoVo> (raw)
In-Reply-To: <20240410093235.5334-3-ast@fiberby.net>
On Wed, Apr 10, 2024 at 09:32:23AM +0000, Asbjørn Sloth Tønnesen wrote:
> Use flow_rule_is_supp_control_flags()
>
> Check the mask, not the key, for unsupported control flags.
>
> Only compile-tested, no access to HW
>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> ---
> drivers/net/ethernet/netronome/nfp/flower/offload.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks for updating:
Reviewed-by: Louis Peens <louis.peens@corigine.com>
next prev parent reply other threads:[~2024-04-11 7:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 9:32 [PATCH net-next v2 0/4] flower: validate control flags Asbjørn Sloth Tønnesen
2024-04-10 9:32 ` [PATCH net-next v2 1/4] flow_offload: add control flag checking helpers Asbjørn Sloth Tønnesen
2024-04-10 11:27 ` Asbjørn Sloth Tønnesen
2024-04-11 6:24 ` Louis Peens
2024-04-10 9:32 ` [PATCH net-next v2 2/4] nfp: flower: fix check for unsupported control flags Asbjørn Sloth Tønnesen
2024-04-11 6:59 ` Louis Peens [this message]
2024-04-10 9:32 ` [PATCH net-next v2 3/4] net: prestera: flower: validate " Asbjørn Sloth Tønnesen
2024-04-10 9:32 ` [PATCH net-next v2 4/4] net: dsa: microchip: ksz9477: " Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZheKTadCKyX23U0k@LouisNoVo \
--to=louis.peens@corigine.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=taras.chornyi@plvision.eu \
--cc=woojung.huh@microchip.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yanguo.li@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).