Re: [patch net-next v4 2/6] selftests: forwarding: move initial root check to the beginning

[Jiri Pirko <jiri@resnulli.us>]

Thu, Apr 18, 2024 at 08:48:20PM CEST, benjamin.poirier@gmail.com wrote:
>On 2024-04-18 18:08 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@nvidia.com>
>> 
>> This check can be done at the very beginning of the script.
>> As the follow up patch needs to add early code that needs to be executed
>> after the check, move it.
>> 
>> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>> ---
>> v3->v4:
>> - removed NUM_NETIFS mode, rephrased the patch subject and description
>>   accordingly
>> ---
>>  tools/testing/selftests/net/forwarding/lib.sh | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>> 
>> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
>> index 7913c6ee418d..b63a5866ce97 100644
>> --- a/tools/testing/selftests/net/forwarding/lib.sh
>> +++ b/tools/testing/selftests/net/forwarding/lib.sh
>> @@ -84,6 +84,11 @@ declare -A NETIFS=(
>>  # e.g. a low-power board.
>>  : "${KSFT_MACHINE_SLOW:=no}"
>>  
>> +if [[ "$(id -u)" -ne 0 ]]; then
>> +	echo "SKIP: need root privileges"
>> +	exit $ksft_skip
>> +fi
>> +
>
>There's a small problem here. ksft_skip is defined in net/lib.sh which
>hasn't yet been imported at this point.
>
>Also, on my system at least, the code in the next patch can run
>successfully as an unprivileged user. So what is this patch needed for
>exactly?

Okay, you are right. Will remove this patch.