From: Ismael Luceno <iluceno@suse.de>
To: Julian Anastasov <ja@ssi.bg>
Cc: linux-kernel@vger.kernel.org, "Firo Yang" <firo.yang@suse.com>,
"Andreas Taschner" <andreas.taschner@suse.com>,
"Michal Kubeček" <mkubecek@suse.com>,
"Simon Horman" <horms@verge.net.au>,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets
Date: Sun, 21 Apr 2024 16:26:59 +0200 [thread overview]
Message-ID: <ZiUiM1tlM3smXSsR@pirotess> (raw)
In-Reply-To: <fd234180-4d6f-313a-0edd-13c821bd4423@ssi.bg>
On 21/Apr/2024 14:01, Julian Anastasov wrote:
<...>
> Thanks for the fix, I'll accept this but skb_is_gso_sctp()
> has comment for pre-condition: skb_is_gso(skb). Can you send v2
> with it?
Thanks; sent!
> I'm guessing what should be the Fixes line, may be?:
>
> Fixes: 90017accff61 ("sctp: Add GSO support")
This seems like the right one.
> because SCTP GSO was added after the IPVS code? Or the
> more recent commit d02f51cbcf12 which adds skb_is_gso_sctp ?
That doesn't seem related at all.
Do we need to check .gso_type in cases like this?
next prev parent reply other threads:[~2024-04-21 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 14:44 [PATCH] ipvs: Fix checksumming on GSO of SCTP packets Ismael Luceno
2024-04-21 11:01 ` Julian Anastasov
2024-04-21 14:26 ` Ismael Luceno [this message]
2024-04-21 15:58 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiUiM1tlM3smXSsR@pirotess \
--to=iluceno@suse.de \
--cc=andreas.taschner@suse.com \
--cc=coreteam@netfilter.org \
--cc=firo.yang@suse.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=mkubecek@suse.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox