From: Jiri Pirko <jiri@resnulli.us>
To: "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyle Swenson <kyle.swenson@est.tech>
Subject: Re: [PATCH net-next v2 2/3] net: pse-pd: pse_core: Fix pse regulator type
Date: Mon, 22 Apr 2024 17:02:18 +0200 [thread overview]
Message-ID: <ZiZ7-n5q3COmPRx6@nanopsycho> (raw)
In-Reply-To: <20240422-fix_poe-v2-2-e58325950f07@bootlin.com>
Mon, Apr 22, 2024 at 03:35:47PM CEST, kory.maincent@bootlin.com wrote:
>From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
>
>Clarify PSE regulator as voltage regulator, not current.
>The PSE (Power Sourcing Equipment) regulator is defined as a voltage
>regulator, maintaining fixed voltage while accommodating varying current.
>
>Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
This looks like a fix. Can you provide "Fixes" tag please and perhaps
send this to -net tree?
Thanks!
>---
> drivers/net/pse-pd/pse_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
>index bad29eaa4d01..795ab264eaf2 100644
>--- a/drivers/net/pse-pd/pse_core.c
>+++ b/drivers/net/pse-pd/pse_core.c
>@@ -294,7 +294,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
> */
> rdesc->id = id;
> rdesc->name = name;
>- rdesc->type = REGULATOR_CURRENT;
>+ rdesc->type = REGULATOR_VOLTAGE;
> rdesc->ops = &pse_pi_ops;
> rdesc->owner = pcdev->owner;
>
>
>--
>2.34.1
>
>
next prev parent reply other threads:[~2024-04-22 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 13:35 [PATCH net-next v2 0/3] net: pse-pd: Fixes for few small issues Kory Maincent (Dent Project)
2024-04-22 13:35 ` [PATCH net-next v2 1/3] net: pse-pd: pse_core: Add missing kdoc return description Kory Maincent (Dent Project)
2024-04-23 8:49 ` Oleksij Rempel
2024-04-22 13:35 ` [PATCH net-next v2 2/3] net: pse-pd: pse_core: Fix pse regulator type Kory Maincent (Dent Project)
2024-04-22 15:02 ` Jiri Pirko [this message]
2024-04-22 16:20 ` Kory Maincent
2024-04-23 8:48 ` Oleksij Rempel
2024-04-22 13:35 ` [PATCH net-next v2 3/3] net: pse-pd: Kconfig: Add missing Regulator API dependency Kory Maincent (Dent Project)
2024-04-23 8:50 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiZ7-n5q3COmPRx6@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox