From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A90A127E37 for ; Tue, 23 Apr 2024 11:52:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713873181; cv=none; b=WwAGOcFbrz7bA18bijkGl7Ns9HgUltyqNqXJuKlDxx90/9aKaqz53Qb7SXuf823/mes06MhILzY0gc1Tsnl2FY7B8MAJ+z23XhdcmzHpmVaMNzZwj5iPSoCmzNJtQm60ZsvWAGJVezNZ/TirnV4OgZcNxHw9kmhE9lNveB9vta8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713873181; c=relaxed/simple; bh=zYeAlMW1SsjV5lzQvuhmib9w9fZnmxBE5X2T4UP4XKM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QACXpgW8VS85F5D4bTtqNnF5B+h6xobiabYD46gvEsOcoCw8MCn+UJgwbQofkTJSkv5uMlVRE7iB0/9eC1i6fFh2TWz/zg5qeoAQIwVeHytwqeEVNM3L1mr7nYtQxhTLO8mNEItuRuhXsWTBJ70cf6Ni4jF0NUctap7OKPhtJPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=J6wdU5rW; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="J6wdU5rW" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-41aa2f6ff00so11047465e9.3 for ; Tue, 23 Apr 2024 04:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713873177; x=1714477977; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zYeAlMW1SsjV5lzQvuhmib9w9fZnmxBE5X2T4UP4XKM=; b=J6wdU5rWu1sYt7DIjHtoJzMw4dG3bEXwc/OYsQtCrZCkQOxlFhW5UeIELWi/Y3dBzf DdXDvgYEQYIj/WgVVgx8zvrf0lpFhG9r1TAGLPaKzjEh/vE7PE79rXWIItWDszAnZc6p +eT7/Z9vZr8BCXkQLev5eHdJuKp9ZoIO/EcWaSui7tzF520jZiNXcUaWdP0O0RxiD0oA fobYl9b7URaCeoKUBkD9nRXBDI30AYMRvA3eSSqa3ffDaI4M2qahv3pltC8SGdpfAaRE XnHzV/iEwQIsRSooB0NIAS0eyrRl4f8El1LJM/lfOPtIeoeABZ6gaWqcl4doIKVW6DRa TGtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713873177; x=1714477977; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zYeAlMW1SsjV5lzQvuhmib9w9fZnmxBE5X2T4UP4XKM=; b=vLAEsRge6BuPUERHE81gw1YBe/pVhceY/8SXEiXqo1ZgeE+rfGFqUf6aWDWSI6UX9Z V4qYacS164m6ysZpjBFEnb/SaYDhEvGuZjNoCHcxTtDgW2h9nRW2hz6G/kOV1KOaWHBy sC6/tz8+ndx85B6jlDj3cwkISYAuLH8n5t5iuBy0b6cU5Uamv/sk1dmRLJK64UxoOPn6 V97LovrqqDGYkFhxE/GD9tz39mho/oTRdV5ql0NZA1ZR49kRrjHdEDK2guOx/y0Ix8RJ LoAQE2GNrjawj99RdiBSRb+xJh8rqBpeHDR0uKDx7JKywQlvY256cDPQgMyvbBHM7KBL 6yYA== X-Gm-Message-State: AOJu0Yxul0j1+ep0ChvTY6g8Kb0JZ8HZ2lgECBX32XLMChCrb+XSnKCj oo2+hcn/Q6nGHwgTe3L31lk9sB+qg1P/W9w0fnZrAr6o1pZgtxK+6YNYLxmr6sc= X-Google-Smtp-Source: AGHT+IGYdlOXhKrV4Xx20GD8wz7O0dwwwQ+1vqgQ4tP2PJTOPwBLbBIdUDSR3guwA85weBtiPCyLSw== X-Received: by 2002:a05:6000:905:b0:33e:c528:c900 with SMTP id cw5-20020a056000090500b0033ec528c900mr9913946wrb.55.1713873177417; Tue, 23 Apr 2024 04:52:57 -0700 (PDT) Received: from localhost (78-80-105-131.customers.tmcz.cz. [78.80.105.131]) by smtp.gmail.com with ESMTPSA id q4-20020adffec4000000b00347f6b5bb6dsm14382274wrs.30.2024.04.23.04.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 04:52:56 -0700 (PDT) Date: Tue, 23 Apr 2024 13:52:55 +0200 From: Jiri Pirko To: =?iso-8859-1?Q?Asbj=F8rn_Sloth_T=F8nnesen?= Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yisen Zhuang , Salil Mehta , Jijie Shao Subject: Re: [PATCH net-next] net: hns3: flower: validate control flags Message-ID: References: <20240422152717.175659-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240422152717.175659-1-ast@fiberby.net> Mon, Apr 22, 2024 at 05:27:16PM CEST, ast@fiberby.net wrote: >This driver currently doesn't support any control flags. > >Use flow_rule_has_control_flags() to check for control flags, >such as can be set through `tc flower ... ip_flags frag`. > >In case any control flags are masked, flow_rule_has_control_flags() >sets a NL extended error message, and we return -EOPNOTSUPP. > >Also propagate extack to hclge_get_cls_key_ip(), and convert it to >return error code. > >Only compile-tested. > >Signed-off-by: Asbjørn Sloth Tønnesen Reviewed-by: Jiri Pirko