From: Antony Antony <antony@phenome.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Antony Antony <antony.antony@secunet.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
devel@linux-ipsec.org, Leon Romanovsky <leon@kernel.org>,
Eyal Birger <eyal.birger@gmail.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA
Date: Tue, 23 Apr 2024 14:34:43 +0200 [thread overview]
Message-ID: <Zieq42gpRYoOFhgM@Antony2201.local> (raw)
In-Reply-To: <20240422060538.466f8232@kernel.org>
On Mon, Apr 22, 2024 at 06:05:38AM -0700, Jakub Kicinski via Devel wrote:
> On Mon, 22 Apr 2024 00:23:58 +0200 Antony Antony wrote:
> > Hi,
> >
> > Inspired by the upcoming IP-TFS patch set, and confusions experienced in
> > the past due to lack of direction attribute on SAs, add a new direction
> > "dir" attribute. It aims to streamline the SA configuration process and
> > enhance the clarity of existing SA attributes.
> >
> > This patch set introduces the 'dir' attribute to SA, aka xfrm_state,
> > ('in' for input or 'out' for output). Alsp add validations of existing
> > direction-specific SA attributes during configuration and in the data
> > path lookup.
> >
> > This change would not affect any existing use case or way of configuring
> > SA. You will notice improvements when the new 'dir' attribute is set.
>
> This breaks the xfrm_policy.sh selftests.
I mised spd lookup use diffrent nla_policy array than xfrma_policy.
I fixed it in v12.
> --
> pw-bot: au
> --
prev parent reply other threads:[~2024-04-23 12:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 22:23 [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Antony Antony
2024-04-21 22:26 ` [PATCH ipsec-next v11 1/4] xfrm: Add Direction to the SA in or out Antony Antony
2024-04-21 22:27 ` [PATCH ipsec-next v11 2/4] xfrm: Add dir validation to "out" data path lookup Antony Antony
2024-04-22 9:54 ` Sabrina Dubroca
2024-04-23 12:36 ` [devel-ipsec] " Antony Antony
2024-04-21 22:29 ` [PATCH ipsec-next v11 3/4] xfrm: Add dir validation to "in" " Antony Antony
2024-04-21 22:30 ` [PATCH ipsec-next v11 4/4] xfrm: Restrict SA direction attribute to specific netlink message types Antony Antony
2024-04-22 13:05 ` [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Jakub Kicinski
2024-04-23 12:34 ` Antony Antony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zieq42gpRYoOFhgM@Antony2201.local \
--to=antony@phenome.org \
--cc=antony.antony@secunet.com \
--cc=davem@davemloft.net \
--cc=devel@linux-ipsec.org \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).