From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35AD777F13 for ; Tue, 23 Apr 2024 13:03:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713877405; cv=none; b=uIwTbzv6LLoVIjyQEEutpusiiHad7rSyc2l7snFBa3Ep5jP8nWyVfJwA3SHFvbUnF2MMpxlZFVOMfHlyiFEP5lPA0mG25GSCRVNBvDcyFba0OoFCiFzzEBMbL+IiPPUTGgmi0AO+H7tUwrllw+8gZEQFufsq+r0PErNai6BeN3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713877405; c=relaxed/simple; bh=HzAJFBGJNzG+mmpiLhhdmnsEu2H7mtL2tnPdNu265DY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FaELBK+mLxageobFzYf7jvaJAJgUQlMmQzhHsAHaoOZeDFmHfXtFQiTXRe68QvP+d5g9FPS5rmGn+gm593xHSDMW2+7Dl6bY3skzwtla0928ug7uRrX0PIg5Ee0mnl9Vk2xX1D7tuyF71qturndenegEURHQJ2GQu6Bc6USKb68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=kxKeOQ1t; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="kxKeOQ1t" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-56e6acb39d4so6571846a12.1 for ; Tue, 23 Apr 2024 06:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713877398; x=1714482198; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yEMgQabm/0/E0TemyCdNw0BH8lVeUgs2Tq3e3AEWvmU=; b=kxKeOQ1tVvhTjUVS0N309epxgdj02/I1JeZrpmbPj1/j1EcZtFkPFBfYvJKPVZKY9V kIM4ZTh8S1IqE2RKuEdzrQSlZYhp7zBSZSiN8mguR4KIpTA6EDEzPXLhPJ7nrvPhGqPu K05Rg1TKs6kjbCw7hfrIJlcOeDtNnpxcTzJqaV2dQbsAVW8DezkWRwRjDYh7T7MwB3WX TG+Zp0mMV2T1aStUV55P2TDcBv8dllaVVlLWIXezKJAh9cZjlRvc8SxZ6mqO6jM24xoq S1msFwXrAfVV2CqT9T5qfeGuoq68OLkS7yYZ1cWclFAEIlsUaSyY49FP9m8XfqwxuSyS 7hTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713877398; x=1714482198; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yEMgQabm/0/E0TemyCdNw0BH8lVeUgs2Tq3e3AEWvmU=; b=TwC9azA7t3dmkCDbRgmZmecGaZfGD6LzMwLCC0MERDYaX1e0RsBn38iX84X3ZWiwAp G06j6800nu+8EthxGKtOg7CsN1GRPG7ojOTk28ugNTwQb5KN9jjHCOc/tGVXC0FnhrrK RgEn8EUsQme0u4EcQPXCFEPl7MtOxQ1fsZ3aJJBHTm3TKtPZZ1PhUAut1+IKjErgZBIB MfRXGGAeFr0ndK7wpwLevqYxX89ZR4Ji2I8fhMdrUcY571PG+irhV9fmcbg7I88M1EYb j0sdJCQt03erfP6Ve0356FxLqQEnki8RsKdrz8GMKAhRuBCZ1MDK6XgS0YYFtZdIL8iY BCbA== X-Gm-Message-State: AOJu0YxQnstDzYsCOBH3qCRXeCp6CGP6ZjJIOT5OflD2hcZKRGcSqtwc L0dQbNpnR/Z1BXQmvo0Al59+AsiKfpU5VpjlMqCFNKfeNrqPyegA+O9lHkpdqGI= X-Google-Smtp-Source: AGHT+IGOf9jTtjwTkllvBAcfwY4LnRurmtji2qf6CII78i3MTciBR8bvSzu25+7rRP8jP1GNkn3hmA== X-Received: by 2002:a50:cd8c:0:b0:570:5b38:1bf2 with SMTP id p12-20020a50cd8c000000b005705b381bf2mr8304894edi.30.1713877398199; Tue, 23 Apr 2024 06:03:18 -0700 (PDT) Received: from localhost (78-80-105-131.customers.tmcz.cz. [78.80.105.131]) by smtp.gmail.com with ESMTPSA id em8-20020a056402364800b0057021b811eesm6669990edb.67.2024.04.23.06.03.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 06:03:15 -0700 (PDT) Date: Tue, 23 Apr 2024 15:03:14 +0200 From: Jiri Pirko To: Geetha sowjanya Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, sgoutham@marvell.com, sbhatta@marvell.com, hkelam@marvell.com Subject: Re: [net-next PATCH v2 0/9] Introduce RVU representors Message-ID: References: <20240422095401.14245-1-gakula@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240422095401.14245-1-gakula@marvell.com> Mon, Apr 22, 2024 at 11:53:52AM CEST, gakula@marvell.com wrote: >This series adds representor support for each rvu devices. >When switchdev mode is enabled, representor netdev is registered >for each rvu device. In implementation of representor model, >one NIX HW LF with multiple SQ and RQ is reserved, where each >RQ and SQ of the LF are mapped to a representor. A loopback channel >is reserved to support packet path between representors and VFs. >CN10K silicon supports 2 types of MACs, RPM and SDP. This >patch set adds representor support for both RPM and SDP MAC >interfaces. > >- Patch 1: Refactors and exports the shared service functions. >- Patch 2: Implements basic representor driver. >- Patch 3: Add devlink support to create representor netdevs that > can be used to manage VFs. >- Patch 4: Implements basec netdev_ndo_ops. >- Patch 5: Installs tcam rules to route packets between representor and > VFs. >- Patch 6: Enables fetching VF stats via representor interface. >- Patch 7: Adds support to sync link state between representors and VFs. >- Patch 8: Enables configuring VF MTU via representor netdevs. >- Patch 9: Add representors for sdp MAC. Could you please add some command outputs to the cover letter? Like $ devlink dev $ devlink port outputs at least. > >----------- >v1-v2: > -Fixed build warnings. > -Address review comments provided by "Kalesh Anakkur Purayil". > >Geetha sowjanya (9): > octeontx2-pf: Refactoring RVU driver > octeontx2-pf: RVU representor driver > octeontx2-pf: Create representor netdev > octeontx2-pf: Add basic net_device_ops > octeontx2-af: Add packet path between representor and VF > octeontx2-pf: Get VF stats via representor > octeontx2-pf: Add support to sync link state between representor and > VFs > octeontx2-pf: Configure VF mtu via representor > octeontx2-pf: Add representors for sdp MAC > > .../net/ethernet/marvell/octeontx2/Kconfig | 8 + > .../ethernet/marvell/octeontx2/af/Makefile | 3 +- > .../ethernet/marvell/octeontx2/af/common.h | 2 + > .../net/ethernet/marvell/octeontx2/af/mbox.h | 73 +++ > .../net/ethernet/marvell/octeontx2/af/npc.h | 1 + > .../net/ethernet/marvell/octeontx2/af/rvu.h | 30 +- > .../marvell/octeontx2/af/rvu_debugfs.c | 27 - > .../marvell/octeontx2/af/rvu_devlink.c | 6 + > .../ethernet/marvell/octeontx2/af/rvu_nix.c | 75 ++- > .../marvell/octeontx2/af/rvu_npc_fs.c | 4 + > .../ethernet/marvell/octeontx2/af/rvu_rep.c | 457 ++++++++++++++ > .../marvell/octeontx2/af/rvu_struct.h | 26 + > .../marvell/octeontx2/af/rvu_switch.c | 20 +- > .../ethernet/marvell/octeontx2/nic/Makefile | 2 + > .../ethernet/marvell/octeontx2/nic/cn10k.c | 4 +- > .../ethernet/marvell/octeontx2/nic/cn10k.h | 2 +- > .../marvell/octeontx2/nic/otx2_common.c | 53 +- > .../marvell/octeontx2/nic/otx2_common.h | 83 ++- > .../marvell/octeontx2/nic/otx2_devlink.c | 47 ++ > .../ethernet/marvell/octeontx2/nic/otx2_pf.c | 305 ++++++--- > .../ethernet/marvell/octeontx2/nic/otx2_reg.h | 1 + > .../marvell/octeontx2/nic/otx2_txrx.c | 35 +- > .../marvell/octeontx2/nic/otx2_txrx.h | 3 +- > .../ethernet/marvell/octeontx2/nic/otx2_vf.c | 18 +- > .../net/ethernet/marvell/octeontx2/nic/rep.c | 596 ++++++++++++++++++ > .../net/ethernet/marvell/octeontx2/nic/rep.h | 51 ++ > 26 files changed, 1707 insertions(+), 225 deletions(-) > create mode 100644 drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c > create mode 100644 drivers/net/ethernet/marvell/octeontx2/nic/rep.c > create mode 100644 drivers/net/ethernet/marvell/octeontx2/nic/rep.h > >-- >2.25.1 > >