From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 599F55A116 for ; Thu, 25 Apr 2024 07:00:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714028443; cv=none; b=IdQonFJCMw+uNAxCfB/dJnSyOQ/M+4CQRkrGjr1/l5dp40J8AsRP54DghUfXrNAk0mN5IldJ46/Ydr7jGqGHiPCQT39DLz0v5ASo2kAkk5PhbJ591RrPuSwqygSJjQjejVD4aOU6CoJw4ad7TIll34GQZLoWFCf+yl2qM6AXzdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714028443; c=relaxed/simple; bh=5gD4270b8K6bujrjPx4bLZQctiTr2ZfBPTKafi5t+m8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OXMvT/SQFc6xNOss567eRubpma3l8hC6Us/UBInApaPdA8BTm/sc9ULcfGNg9dImlwiZKIrGtsyiYfffmqGAdSGKv13774UbQIG5etOFoORVwWPanQ0sopx0YHOP2r6of9EOni8RHLrvWZRgzEzc9j5dKFoqoDyLoKYzZp+yZeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=ZK9lZ9qy; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="ZK9lZ9qy" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a556d22fa93so66567766b.3 for ; Thu, 25 Apr 2024 00:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1714028440; x=1714633240; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BcX5U+8n/ANNJt6fW16Sve1uLIZ1XhN9l3ZH/EGG0xc=; b=ZK9lZ9qy/evNHKDlXKfIcBpn3wZm6UE1zpgGoXPWxqn7qKvUixkSjdt+TfPKNEscuY gWL6qKLhjl5tAl2tyk1X0L1b4CN05+6DhaNynR3FIOk5cLYx9eOyejVNuYSS+DKIbZPo NbFOq3b/fl/FbRP1AWgxWZiGlpBkqn0IoQeaF6kM7LoefUEYQ33C+nH7bEO27bmVP8km hRMOVXS83AhNU/Gs7J6FLIcPI7yhFK3mBf+sScGgzO2vJsuN3B+etdtK/4ecorSrYr7P cdwxuVEvHbqX39j53AKJijFQt2jui0lBbwm+gw+KTeLKYFMGmXl/wPDrvjmpAfw6QQPY qhjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714028440; x=1714633240; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BcX5U+8n/ANNJt6fW16Sve1uLIZ1XhN9l3ZH/EGG0xc=; b=gKS2yXSYULWX1UcTdW+fSGXIDXf6zZfvP7154+tqCru9iVFn4MmL+Gk5KU8Kq39Mmu aiaJJvNr/zaYVBvfY/NxnbTEP7bwvd40V1TCgPhWghPUhYWNPh7+3o/6uu7e/22HJU1l tl0O5NeG2DSCsrDLMQNVmPNJ1ibgC/eBDbLgj+Q2SZU1XQW6GB7IupfTtjvq1GnbZZG6 gpuglwlC31Jx6g97UTsjz5V+/wNY1F5bWHYTsqDBFOu4AM4m3ebMC+e+kJvV0BAwbLYT YY0D8+KGksVb3wr1DLEZeeafRXnHXQeikyO3P1Bv3YGYYFqiZoLDoJo/u4lEEicwsVP2 oJsQ== X-Gm-Message-State: AOJu0YxTwcGjfcfSxvbWK+hQ0WB01fNO30k4LJ89CsSygmdftQrmD0mi yH0FEvo9n2iSROJxYYPOTyTSDlS/rQcM6V3TEseQ2Ojcn+xI5lpjw93Vu8UaLDA= X-Google-Smtp-Source: AGHT+IH7XBrrHA7tkNl1BzhyNcrgopp0eeXlsfxHmqSzga8TfWcFIDXSluCL+yE0uHqZSLgkyVA9NQ== X-Received: by 2002:a17:906:2650:b0:a55:b05b:cdf2 with SMTP id i16-20020a170906265000b00a55b05bcdf2mr2765517ejc.21.1714028439495; Thu, 25 Apr 2024 00:00:39 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id s8-20020a170906500800b00a4e24d259edsm9148480ejj.167.2024.04.25.00.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 00:00:38 -0700 (PDT) Date: Thu, 25 Apr 2024 09:00:34 +0200 From: Jiri Pirko To: Geethasowjanya Akula Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "davem@davemloft.net" , "pabeni@redhat.com" , "edumazet@google.com" , Sunil Kovvuri Goutham , Subbaraya Sundeep Bhatta , Hariprasad Kelam Subject: Re: [EXTERNAL] Re: [net-next PATCH v2 0/9] Introduce RVU representors Message-ID: References: <20240422095401.14245-1-gakula@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Thu, Apr 25, 2024 at 07:09:01AM CEST, gakula@marvell.com wrote: > > >> -----Original Message----- >> From: Jiri Pirko >> Sent: Wednesday, April 24, 2024 8:12 PM >> To: Geethasowjanya Akula >> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kuba@kernel.org; >> davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil >> Kovvuri Goutham ; Subbaraya Sundeep Bhatta >> ; Hariprasad Kelam >> Subject: Re: [EXTERNAL] Re: [net-next PATCH v2 0/9] Introduce RVU >> representors >> >> Tue, Apr 23, 2024 at 05:39:15PM CEST, gakula@marvell.com wrote: >> > >> > >> >> -----Original Message----- >> >> From: Jiri Pirko >> >> Sent: Tuesday, April 23, 2024 6:33 PM >> >> To: Geethasowjanya Akula >> >> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; >> >> kuba@kernel.org; davem@davemloft.net; pabeni@redhat.com; >> >> edumazet@google.com; Sunil Kovvuri Goutham >> ; >> >> Subbaraya Sundeep Bhatta ; Hariprasad Kelam >> >> >> >> Subject: [EXTERNAL] Re: [net-next PATCH v2 0/9] Introduce RVU >> >> representors >> >> --------------------------------------------------------------------- >> >> - Mon, Apr 22, 2024 at 11:53:52AM CEST, gakula@marvell.com wrote: >> >> >This series adds representor support for each rvu devices. >> >> >When switchdev mode is enabled, representor netdev is registered for >> >> >each rvu device. In implementation of representor model, one NIX HW >> >> >LF with multiple SQ and RQ is reserved, where each RQ and SQ of the >> >> >LF are mapped to a representor. A loopback channel is reserved to >> >> >support packet path between representors and VFs. >> >> >CN10K silicon supports 2 types of MACs, RPM and SDP. This patch set >> >> >adds representor support for both RPM and SDP MAC interfaces. >> >> > >> >> >- Patch 1: Refactors and exports the shared service functions. >> >> >- Patch 2: Implements basic representor driver. >> >> >- Patch 3: Add devlink support to create representor netdevs that >> >> > can be used to manage VFs. >> >> >- Patch 4: Implements basec netdev_ndo_ops. >> >> >- Patch 5: Installs tcam rules to route packets between representor and >> >> > VFs. >> >> >- Patch 6: Enables fetching VF stats via representor interface. >> >> >- Patch 7: Adds support to sync link state between representors and VFs. >> >> >- Patch 8: Enables configuring VF MTU via representor netdevs. >> >> >- Patch 9: Add representors for sdp MAC. >> >> >> >> >> >> Could you please add some command outputs to the cover letter? Like $ >> >> devlink dev $ devlink port >> >> >> >#devlink dev eswitch set pci/0002:1c:00.0 mode switchdev >VF representors are created for each VF when switch mode is set switchdev on representor PCI device ># devlink dev eswitch set pci/0002:1c:00.0 mode switchdev ># ip link show >25: r0p1: mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 > link/ether 32:0f:0f:f0:60:f1 brd ff:ff:ff:ff:ff:ff >26: r1p1: mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 > link/ether 3e:5d:9a:4d:e7:7b brd ff:ff:ff:ff:ff:ff > >Sorry if I was not clear before. Hope these answers you question. Again, please add outputs of: devlink dev devlink port I'm not sure why this was not clear the first time I wrote it. > >> >> ? >> >> >> outputs at least. >> >> >> >> >> >> > >> >> >----------- >> >> >v1-v2: >> >> > -Fixed build warnings. >> >> > -Address review comments provided by "Kalesh Anakkur Purayil". >> >> > >> >> >Geetha sowjanya (9): >> >> > octeontx2-pf: Refactoring RVU driver >> >> > octeontx2-pf: RVU representor driver >> >> > octeontx2-pf: Create representor netdev >> >> > octeontx2-pf: Add basic net_device_ops >> >> > octeontx2-af: Add packet path between representor and VF >> >> > octeontx2-pf: Get VF stats via representor >> >> > octeontx2-pf: Add support to sync link state between representor and >> >> > VFs >> >> > octeontx2-pf: Configure VF mtu via representor >> >> > octeontx2-pf: Add representors for sdp MAC >> >> > >> >> > .../net/ethernet/marvell/octeontx2/Kconfig | 8 + >> >> > .../ethernet/marvell/octeontx2/af/Makefile | 3 +- >> >> > .../ethernet/marvell/octeontx2/af/common.h | 2 + >> >> > .../net/ethernet/marvell/octeontx2/af/mbox.h | 73 +++ >> >> > .../net/ethernet/marvell/octeontx2/af/npc.h | 1 + >> >> > .../net/ethernet/marvell/octeontx2/af/rvu.h | 30 +- >> >> > .../marvell/octeontx2/af/rvu_debugfs.c | 27 - >> >> > .../marvell/octeontx2/af/rvu_devlink.c | 6 + >> >> > .../ethernet/marvell/octeontx2/af/rvu_nix.c | 75 ++- >> >> > .../marvell/octeontx2/af/rvu_npc_fs.c | 4 + >> >> > .../ethernet/marvell/octeontx2/af/rvu_rep.c | 457 ++++++++++++++ >> >> > .../marvell/octeontx2/af/rvu_struct.h | 26 + >> >> > .../marvell/octeontx2/af/rvu_switch.c | 20 +- >> >> > .../ethernet/marvell/octeontx2/nic/Makefile | 2 + >> >> > .../ethernet/marvell/octeontx2/nic/cn10k.c | 4 +- >> >> > .../ethernet/marvell/octeontx2/nic/cn10k.h | 2 +- >> >> > .../marvell/octeontx2/nic/otx2_common.c | 53 +- >> >> > .../marvell/octeontx2/nic/otx2_common.h | 83 ++- >> >> > .../marvell/octeontx2/nic/otx2_devlink.c | 47 ++ >> >> > .../ethernet/marvell/octeontx2/nic/otx2_pf.c | 305 ++++++--- >> >> > .../ethernet/marvell/octeontx2/nic/otx2_reg.h | 1 + >> >> > .../marvell/octeontx2/nic/otx2_txrx.c | 35 +- >> >> > .../marvell/octeontx2/nic/otx2_txrx.h | 3 +- >> >> > .../ethernet/marvell/octeontx2/nic/otx2_vf.c | 18 +- >> >> > .../net/ethernet/marvell/octeontx2/nic/rep.c | 596 >> >> > ++++++++++++++++++ .../net/ethernet/marvell/octeontx2/nic/rep.h | >> >> > 51 ++ >> >> > 26 files changed, 1707 insertions(+), 225 deletions(-) create mode >> >> > 100644 drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c >> >> > create mode 100644 drivers/net/ethernet/marvell/octeontx2/nic/rep.c >> >> > create mode 100644 drivers/net/ethernet/marvell/octeontx2/nic/rep.h >> >> > >> >> >-- >> >> >2.25.1 >> >> > >> >> >