From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
bcm-kernel-feedback-list@broadcom.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
mcoquelin.stm32@gmail.com, richardcochran@gmail.com,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC
Date: Sat, 11 May 2024 18:12:38 +0100 [thread overview]
Message-ID: <Zj+nBpQn1cqTMJxQ@shell.armlinux.org.uk> (raw)
In-Reply-To: <4ede8911-827d-4fad-b327-52c9aa7ed957@lunn.ch>
On Sat, May 11, 2024 at 06:16:52PM +0200, Andrew Lunn wrote:
> > + /* This device interface is directly attached to the switch chip on
> > + * the SoC. Since no MDIO is present, register fixed_phy.
> > + */
> > + brcm_priv->phy_dev =
> > + fixed_phy_register(PHY_POLL,
> > + &dwxgmac_brcm_fixed_phy_status, NULL);
> > + if (IS_ERR(brcm_priv->phy_dev)) {
> > + dev_err(&pdev->dev, "%s\tNo PHY/fixed_PHY found\n", __func__);
> > + return -ENODEV;
> > + }
> > + phy_attached_info(brcm_priv->phy_dev);
>
> What switch is it? Will there be patches to extend SF2?
... and why is this legacy fixed_phy even necessary when stmmac uses
phylink which supports fixed links, including with custom fixed status?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-05-11 17:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 0:03 [PATCH, net-next, 0/2] net: stmmac: support for BCM8958x SoC Jitendra Vegiraju
2024-05-10 0:03 ` [PATCH, net-next, 1/2] net: stmmac: Export dma_ops for reuse in glue drivers Jitendra Vegiraju
2024-05-10 0:03 ` [PATCH, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC Jitendra Vegiraju
2024-05-11 1:35 ` Jakub Kicinski
2024-05-11 1:59 ` [PATCH v2, " Jitendra Vegiraju
2024-05-11 2:08 ` Jakub Kicinski
2024-05-13 16:47 ` Jitendra Vegiraju
2024-05-11 16:16 ` Andrew Lunn
2024-05-11 17:12 ` Russell King (Oracle) [this message]
2024-05-11 17:19 ` Andrew Lunn
2024-05-11 19:35 ` Russell King (Oracle)
2024-05-11 17:50 ` Andrew Lunn
2024-05-11 19:36 ` Russell King (Oracle)
2024-05-13 17:32 ` Jitendra Vegiraju
2024-05-13 18:07 ` Andrew Lunn
2024-05-14 8:19 ` Russell King (Oracle)
2024-05-14 16:18 ` Florian Fainelli
2024-05-11 19:34 ` Russell King (Oracle)
2024-05-13 17:38 ` Jitendra Vegiraju
2024-05-13 17:41 ` Russell King (Oracle)
2024-05-13 19:52 ` Andrew Lunn
2024-05-12 8:35 ` Simon Horman
2024-05-17 23:50 ` [PATCH, " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj+nBpQn1cqTMJxQ@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jitendra.vegiraju@broadcom.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).