From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7563B57C84; Thu, 2 May 2024 23:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714691234; cv=none; b=SDlZ8eH1Z2o/9RIugDIilyxHmNXwtkb0ZVALBGd2L48Yvumrn3eJnXf2u69lndrgRLuBqyRYduledB0R6RPDlvN1vq8/fnkIgWPebZwIipOFLtvEXq2/IlkUi9DwZjDDlEjm+o/uz5uA3nWINvtkPV4nTcNFG8Zww/NAbP3rGQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714691234; c=relaxed/simple; bh=Hwv7feoOXYxWl+2p0rOmp4K2sjI+B0d+XTLeu1NjFTA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FxREbvzVt3rEqp9oJya7pMBVT1wlgNFfWZxcSUHSvuHmEzHnSznpsAueOPGHUpoIf3s7j6+xioOCWLi6wYVTLpqzzJYTFTYk+ycY9QADi8aNQKbTRnwbUIPIEJLJ+1wKklfQyfXtWSCLgrmVsl1syxdFNI/ODobhSNRQA6fbAUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Lb7IPdzU; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Lb7IPdzU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ggldfb+SnGyHf9Y0PSAxHLGif2nJQj+Ec7fEJVGb75o=; b=Lb7IPdzUBf5fxuHKvzI9o6uLSf RnddZfhFt7Wuoo+yO08qYqKgdD9hHqwCFkcXYKBIB+4X+0JdnnJtpsqFaMT0wnnv6M9IkA/gRz3dO CfH7Qf8EWypK6L/TUeZ0Du7foM4ykeRc3vnVXR/Q8UVZHuQgHqu0NqfWmBjcCr8SvcyvuW4Mkqc28 xofGGkYwiKsmCUnJHJzx95tE5MA+DQjtoUN9fqejczoSwHyZ+Ikhq12KowJl3pBhgYGyiVQ4bqUvD yp2jYj6J2Re5TMWfN03xgZqm/nkb4xW8EoAJALaAt82gNWBFuA9GWVogzaVAH0hDHMU3YDgdcYW0+ OkmsCkaw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2fW5-0000000ECkp-3WzA; Thu, 02 May 2024 23:07:05 +0000 Date: Thu, 2 May 2024 16:07:05 -0700 From: Luis Chamberlain To: Liviu Dudau Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v7 00/16] mm: jit/text allocator Message-ID: References: <20240429121620.1186447-1-rppt@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain On Thu, May 02, 2024 at 11:50:36PM +0100, Liviu Dudau wrote: > On Mon, Apr 29, 2024 at 09:29:20AM -0700, Luis Chamberlain wrote: > > On Mon, Apr 29, 2024 at 03:16:04PM +0300, Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > > > Hi, > > > > > > The patches are also available in git: > > > https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=execmem/v7 > > > > > > v7 changes: > > > * define MODULE_{VADDR,END} for riscv32 to fix the build and avoid > > > #ifdefs in a function body > > > * add Acks, thanks everybody > > > > Thanks, I've pushed this to modules-next for further exposure / testing. > > Given the status of testing so far with prior revisions, in that only a > > few issues were found and that those were fixed, and the status of > > reviews, this just might be ripe for v6.10. > > Looks like there is still some work needed. I've picked up next-20240501 > and on arch/mips with CONFIG_MODULE_COMPRESS_XZ=y and CONFIG_MODULE_DECOMPRESS=y > I fail to load any module: > > # modprobe rfkill > [11746.539090] Invalid ELF header magic: != ELF > [11746.587149] execmem: unable to allocate memory > modprobe: can't load module rfkill (kernel/net/rfkill/rfkill.ko.xz): Out of memory > > The (hopefully) relevant parts of my .config: Thanks for the report! Any chance we can get you to try a bisection? I think it should take 2-3 test boots. To help reduce scope you try modules-next: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next Then can you check by resetting your tree to commmit 3fbe6c2f820a76 (mm: introduce execmem_alloc() and execmem_free()"). I suspect that should boot, so your bad commit would be the tip 3c2c250cb3a5fbb ("bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of"). That gives us only a few commits to bisect: git log --oneline 3fbe6c2f820a76bc36d5546bda85832f57c8fce2.. 3c2c250cb3a5 (HEAD -> modules-next, korg/modules-next) bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of 11e8e65cce5c kprobes: remove dependency on CONFIG_MODULES e10cbc38697b powerpc: use CONFIG_EXECMEM instead of CONFIG_MODULES where appropriate 4da3d38f24c5 x86/ftrace: enable dynamic ftrace without CONFIG_MODULES 13ae3d74ee70 arch: make execmem setup available regardless of CONFIG_MODULES 460bbbc70a47 powerpc: extend execmem_params for kprobes allocations e1a14069b5b4 arm64: extend execmem_info for generated code allocations 971e181c6585 riscv: extend execmem_params for generated code allocations 0fa276f26721 mm/execmem, arch: convert remaining overrides of module_alloc to execmem 022cef244287 mm/execmem, arch: convert simple overrides of module_alloc to execmem With 2-3 boots we should be to tell which is the bad commit. Luis