From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, razor@blackwall.org
Subject: Re: [PATCH net] selftests: test_bridge_neigh_suppress.sh: Try to stabilize test
Date: Mon, 6 May 2024 11:08:31 +0300 [thread overview]
Message-ID: <ZjiP_3XiXJ0CoChQ@shredder> (raw)
In-Reply-To: <20240505145412.1235257-1-idosch@nvidia.com>
On Sun, May 05, 2024 at 05:54:12PM +0300, Ido Schimmel wrote:
> The arping and ndisc6 test cases sometimes pass on non-debug kernels
> [1], but fail on debug kernels [2] even when it is the same branch that
> is being tested in the netdev CI.
>
> These are the only test cases that are unstable and the only ones that
> use a timeout. Therefore, my only theory is that the timeout is too
> short although it is currently set to 5 seconds.
>
> Try to stabilize these test cases by using a timeout of 20 seconds.
>
> [1]
> # Per-port ARP suppression - VLAN 10
> # ----------------------------------
> # TEST: arping [ OK ]
> # TEST: ARP suppression [ OK ]
> # TEST: "neigh_suppress" is on [ OK ]
> # TEST: arping [ OK ]
> # TEST: ARP suppression [ OK ]
>
> [2]
> # Per-port ARP suppression - VLAN 10
> # ----------------------------------
> # TEST: arping [FAIL]
> # TEST: ARP suppression [ OK ]
> # TEST: "neigh_suppress" is on [ OK ]
> # TEST: arping [FAIL]
> # TEST: ARP suppression [ OK ]
>
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Closes: https://lore.kernel.org/netdev/20240426074015.251854d4@kernel.org/
> Fixes: 7648ac72dcd7 ("selftests: net: Add bridge neighbor suppression test")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> I'm unable to reproduce these failures locally. Tried with both regular
> and debug configs. Let's wait for the CI results and see if this patch
> helps.
> ---
Checked the results. Looks like it didn't help. Don't have other ideas
at the moment.
pw-bot: changes-requested
next prev parent reply other threads:[~2024-05-06 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 14:54 [PATCH net] selftests: test_bridge_neigh_suppress.sh: Try to stabilize test Ido Schimmel
2024-05-06 8:08 ` Ido Schimmel [this message]
2024-05-06 13:36 ` Jakub Kicinski
2024-05-07 10:58 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjiP_3XiXJ0CoChQ@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).