From: Sabrina Dubroca <sd@queasysnail.net>
To: Antony Antony <antony.antony@secunet.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Shuah Khan <shuah@kernel.org>,
devel@linux-ipsec.org
Subject: Re: [PATCH net-next v3 0/2] fix icmp error source address over xfrm tunnel
Date: Mon, 6 May 2024 15:36:15 +0200 [thread overview]
Message-ID: <ZjjczzsSz6wwUHd5@hog> (raw)
In-Reply-To: <cover.1714982035.git.antony.antony@secunet.com>
2024-05-06, 09:58:26 +0200, Antony Antony wrote:
> Hi,
> This fix, originally intended for XFRM/IPsec, has been recommended by
> Steffen Klassert to submit to the net tree.
>
> The patch addresses a minor issue related to the IPv4 source address of
> ICMP error messages, which originated from an old 2011 commit:
>
> 415b3334a21a ("icmp: Fix regression in nexthop resolution during replies.")
>
> The omission of a "Fixes" tag in the following commit is deliberate
> to prevent potential test failures and subsequent regression issues
> that may arise from backporting this patch all stable kerenels.
What kind of regression do you expect? If there's a risk of
regression, I'm not sure net-next is that much "better" than net or
stable. If a user complains about the new behavior breaking their
setup, my understanding is that you would likely have to revert the
patch anyway, or at least add some way to toggle the behavior.
--
Sabrina
next prev parent reply other threads:[~2024-05-06 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 7:58 [PATCH net-next v3 0/2] fix icmp error source address over xfrm tunnel Antony Antony
2024-05-06 8:00 ` [PATCH net-next v3 1/2] xfrm: fix source address in icmp error generation from IPsec gateway Antony Antony
2024-05-06 8:05 ` [PATCH net-next v3 2/2] selftests/net: add ICMP unreachable over IPsec tunnel Antony Antony
2024-05-06 13:28 ` Jakub Kicinski
2024-05-06 15:37 ` Antony Antony
2024-05-06 23:59 ` Jakub Kicinski
2024-05-07 8:10 ` Sabrina Dubroca
2024-05-06 13:36 ` Sabrina Dubroca [this message]
2024-05-06 15:57 ` [PATCH net-next v3 0/2] fix icmp error source address over xfrm tunnel Antony Antony
2024-05-07 8:52 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjjczzsSz6wwUHd5@hog \
--to=sd@queasysnail.net \
--cc=antony.antony@secunet.com \
--cc=davem@davemloft.net \
--cc=devel@linux-ipsec.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).