From: Breno Leitao <leitao@debian.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
netdev@vger.kernel.org,
"open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] IB/hfi1: Do not use custom stat allocator
Date: Tue, 7 May 2024 03:07:05 -0700 [thread overview]
Message-ID: <Zjn9ScolCtJV+ZCp@gmail.com> (raw)
In-Reply-To: <20240505141032.GE68202@unreal>
Hello Leon,
On Sun, May 05, 2024 at 05:10:32PM +0300, Leon Romanovsky wrote:
> On Fri, May 03, 2024 at 04:13:31AM -0700, Breno Leitao wrote:
> > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> > convert veth & vrf"), stats allocation could be done on net core
> > instead of in this driver.
> >
> > With this new approach, the driver doesn't have to bother with error
> > handling (allocation failure checking, making sure free happens in the
> > right spot, etc). This is core responsibility now.
> >
> > Remove the allocation in the hfi1 driver and leverage the network
> > core allocation instead.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > drivers/infiniband/hw/hfi1/ipoib_main.c | 19 +++----------------
> > 1 file changed, 3 insertions(+), 16 deletions(-)
>
> Please use rdma-next in the PATCH subject line, when sending patches for RDMA.
Thanks for the heads-up. I will make sure I use rdma-next in the next RDMA patches.
next prev parent reply other threads:[~2024-05-07 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 11:13 [PATCH net-next 1/2] IB/hfi1: Do not use custom stat allocator Breno Leitao
2024-05-03 11:13 ` [PATCH net-next 2/2] IB/hfi1: Remove generic .ndo_get_stats64 Breno Leitao
2024-05-04 15:03 ` Simon Horman
2024-05-05 14:16 ` Leon Romanovsky
2024-05-04 15:03 ` [PATCH net-next 1/2] IB/hfi1: Do not use custom stat allocator Simon Horman
2024-05-05 14:10 ` Leon Romanovsky
2024-05-07 10:07 ` Breno Leitao [this message]
2024-05-05 14:10 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjn9ScolCtJV+ZCp@gmail.com \
--to=leitao@debian.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).