netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sirius <sirius@trudheim.com>
To: Gedalya <gedalya@gedalya.net>
Cc: netdev@vger.kernel.org
Subject: Re: iproute2: color output should assume dark background
Date: Thu, 23 May 2024 08:39:04 +0200	[thread overview]
Message-ID: <Zk7kiFLLcIM27bEi@photonic.trudheim.com> (raw)
In-Reply-To: <173e0ec8-583a-4d5a-931f-81d08e43fe2b@gedalya.net>

In days of yore (Thu, 23 May 2024), Gedalya thus quoth: 
> Hello,

Good morning,

> Debian is now building iproute2 with color output on by default. This
> brings attention to the fact that iproute2 defaults to a color palette
> suitable for light backgrounds.
> 
> The COLORFGBG environment variable, if present and correctly set would
> select a dark background. However COLORFGBG is neither ubiquitous nor
> standard. It wouldn't typically be present in a non-graphical vt, nor is
> it presnet in XFCE and many other desktop environments.
> 
> Dark backgrounds seem to be the more common default, and it seems many
> people stick to that in actual use.

FWIW, I use a light background as that is easier for me to read.

Might I suggest that instead of fueling a bikeshed war about what terminal
background should be used, read what the background is of the console and
adapt the foreground colours to that. I would guess that means holding two
sets of the eight colours and if the background is "dark", use the lighter
set and if the background is "light", use the darker set. Then the
variable is superfluous.

Make it usable for everyone rather than just a subset of users based on
personal preference.

> The dark blue used by the ip command for IPv6 addresses is particularly
> hard to read on a dark background. It's really important for the ip
> command to provide basic usability e.g. when manually bringing up
> networking at the console in an emergency. I find that fiddling with
> extra details just to disable or improve the colors would be an
> unwelcome nuisance in such situations, but the Debian maintainer
> outright refuses to revert this change, without explanation or
> discussion.
> 
> Instead the maintainer suggested I submit a patch upstream, which I will
> do. I've never contributed here before, so your patience and guidance
> would be very highly appreciated.
> 
> Ref: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071582

Kudos for that.

-- 
Kind regards,

/S

  parent reply	other threads:[~2024-05-23  6:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 19:21 iproute2: color output should assume dark background Gedalya
2024-05-22 19:27 ` Dragan Simic
2024-05-23  6:39 ` Sirius [this message]
2024-05-23  7:08   ` Gedalya
2024-05-23  7:57     ` Sirius
2024-05-23  8:05       ` Sirius
2024-05-23 12:36       ` Dragan Simic
2024-05-23 13:02         ` Sirius
2024-05-23 13:04         ` Gedalya
2024-05-23 13:19           ` Sirius
2024-05-23 13:47             ` Dragan Simic
2024-05-28  9:07             ` David Laight
2024-05-28  9:40               ` Gedalya
2024-05-23 13:23           ` Dragan Simic
2024-05-23 13:39             ` Gedalya
2024-05-23 14:02               ` Dragan Simic
2024-05-23 14:11                 ` Gedalya
2024-05-23 14:24                   ` Dragan Simic
2024-05-23 14:33                     ` Gedalya
2024-05-23 14:59                       ` Stephen Hemminger
2024-05-23 15:17                         ` Gedalya
2024-05-23 13:50             ` Gedalya
2024-05-23 14:07               ` Dragan Simic
2024-05-23 14:13                 ` Gedalya
2024-05-23 14:26                   ` Dragan Simic
2024-05-23 14:11               ` Sirius
2024-05-23 14:19                 ` Gedalya
2024-05-23 14:28                   ` Dragan Simic
2024-05-23 14:29                     ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zk7kiFLLcIM27bEi@photonic.trudheim.com \
    --to=sirius@trudheim.com \
    --cc=gedalya@gedalya.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).