Re: [PATCH net-next v3 13/24] ovpn: implement TCP transport

Jakub Kicinski
2024-05-13T15:34:53Z

On Mon, 13 May 2024 15:37:54 +0200 Antonio Quartulli wrote:
> > * @netif_rx_ring: queue of packets to be sent to the netdevice via NAPI
> > * @napi: NAPI object
> > * @sock: the socket being used to talk to this peer
> > + * @tcp.tx_ring: queue for packets to be forwarded to userspace (TCP only)
> > + * @tcp.tx_work: work for processing outgoing socket data (TCP only)
> > + * @tcp.rx_work: wok for processing incoming socket data (TCP only)
> > + * @tcp.raw_len: next packet length as read from the stream (TCP only)
>
> can you please help me with the following warning from kerneldoc?
> As you can see below, raw_len is an array.
>
> May that be the reason why the script isn't picking it up correctly?
>
> drivers/net/ovpn/peer.h:101: warning: Function parameter or struct
> member 'raw_len' not described in 'ovpn_peer'
> drivers/net/ovpn/peer.h:101: warning: Excess struct member 'tcp.raw_len'
> description in 'ovpn_peer'
>
> (line number may differ as I am in the middle of a rebase)

Hm, the script itself is a fairly simple file of perl regexps
You can try to tweak it and send a fix to the list.
I presume using sizeof() to declare an array is fairly uncommon.
Or forgo the sizeof() and use literal 2? :)