Re: [PATCH net-next v3 04/24] ovpn: add basic interface creation/destruction/management routines

Jakub Kicinski
2024-05-09T01:06:31Z

On Wed, 8 May 2024 16:52:27 +0200 Sabrina Dubroca wrote:
> > +static int ovpn_net_open(struct net_device *dev)
> > +{
> > + struct in_device *dev_v4 = __in_dev_get_rtnl(dev);
> > +
> > + if (dev_v4) {
> > + /* disable redirects as Linux gets confused by ovpn handling
> > + * same-LAN routing
> > + */
> > + IN_DEV_CONF_SET(dev_v4, SEND_REDIRECTS, false);
> > + IPV4_DEVCONF_ALL(dev_net(dev), SEND_REDIRECTS) = false;
>
> Jakub, are you ok with that? This feels a bit weird to have in the
> middle of a driver.

Herm, I only looked at the netlink bits so far.
Would be good to get more details on the problem and see if we can fix
it more directly.