From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 899E142A82 for ; Mon, 13 May 2024 18:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715626022; cv=none; b=RIPHQ8XQm62nh7T32LrgB0rkqzDUWS2LgwQ/Jk26fcUwNdq559CwiHdYlNR9J/T6LL7fwq0wwV09ArYMVEx66pnAxU7brBsBU2c3HvLEV2v9WIYze8d8cT5r5WhkbdXBZa0aeG8dYdimU0KHDSWlP8RYT83UPrOSjr32X2VIDb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715626022; c=relaxed/simple; bh=1u9/b9gk/Tl5ozsdOKNx/td/R95i1KBWjQylrJWvc1k=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s+IKfp4L1B1qDydkfEn14ks9cyxH8yAsgbyVTkb0X4WMKpmqTfcbfcE39aNI/J66dTj2+F9/qrbIU5olQ9/BCgnDxbcc8DMtxQ0fgco9yIWo/duFge9QhMsp0FDhbc2n4d7hbZG8gLRzHlSuaieFHvHbb5T7qDzZ6vvl7n44xDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=GZha+N5Y; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="GZha+N5Y" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1ee954e0aa6so35908395ad.3 for ; Mon, 13 May 2024 11:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1715626021; x=1716230821; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=4/YpgsmxEh7NnZ1zRADZ2HbHM07VTZzuSca8drjzUhU=; b=GZha+N5Yez+iTz/TJMB89wFfdlYKZVoMOL6XtCKFwXwvnC9bK+icU4rmf7z0o5xRtI YJhwmdcng42I136HEmlU6AhQpa5HJHx/uJTPh20EewuS+/5YCurgrqQ8/2rGf53Blzup 15FMB9VxAHNF0PugoirJhF4ti2jn+lJP92tcw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715626021; x=1716230821; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4/YpgsmxEh7NnZ1zRADZ2HbHM07VTZzuSca8drjzUhU=; b=IAcO7LUPZB18b6O1z4YUawcM9mVS/WF/yb83joh5J3ns+qyPOszgRqYT20Pqn0QgnF u+kbusVFo0EJ/MFdMR6mh314EOAHaL0MTNpmIL9/twXqVoNO6maJ567tv2lucUMISdck VNGH1iLUmv63Ybbkih1KLonT9nZDNu/LZFPAlS/ipnn/XCxbclPScO7ojkpQ2GUJeJso ds/t+Oe15hSxeE8dmnp/6ZboDTPe9nwc8lZaZpT1DZxrg/amK7FtAEwbWP6IvGAk24qR dZsATRRg7romOjloCKB+xhRyCyRlELbqvUvxni5mh61l31EQkR7KMbT3HsNOudjOa9QV mifA== X-Forwarded-Encrypted: i=1; AJvYcCVczzQgaH0wX2dHTJpdqvwHiWIk+QyiKrb3VCIAvtiE6nryGfGktK3Sf0YB8Wp/BRhIT73dYKzHcoMoCG/EcA7EJ9D/h7XX X-Gm-Message-State: AOJu0YxFhYqJD+QXcfQNJeuHsxqifQiz2f20SCqn2Gi/e+nG7BKCUkIz CchJjwqd4ATlbuUhv+tJ4er4PtsZQhoQheTCk67VYJubxjjNQLIuJAheFVrx+b0= X-Google-Smtp-Source: AGHT+IHbSrhUBqN1/ZWPPfyWlFBVdHyHLIR+khL/KKrN4dLXG5CPpLVAkZ3pgSvHmoFsy/dhzVKAsA== X-Received: by 2002:a17:902:f552:b0:1ed:1d37:267e with SMTP id d9443c01a7336-1ef43e281b0mr137384885ad.16.1715626020880; Mon, 13 May 2024 11:47:00 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d168esm82664875ad.32.2024.05.13.11.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 11:47:00 -0700 (PDT) Date: Mon, 13 May 2024 11:46:57 -0700 From: Joe Damato To: Jakub Kicinski , Tariq Toukan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, zyjzyj2000@gmail.com, nalramli@fastly.com, Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , "open list:MELLANOX MLX5 core VPI driver" Subject: Re: [PATCH net-next v2 1/1] net/mlx5e: Add per queue netdev-genl stats Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , Tariq Toukan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, zyjzyj2000@gmail.com, nalramli@fastly.com, Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , "open list:MELLANOX MLX5 core VPI driver" References: <20240510041705.96453-1-jdamato@fastly.com> <20240510041705.96453-2-jdamato@fastly.com> <20240513075827.66d42cc1@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 13, 2024 at 10:33:28AM -0700, Joe Damato wrote: > On Mon, May 13, 2024 at 07:58:27AM -0700, Jakub Kicinski wrote: > > On Fri, 10 May 2024 04:17:04 +0000 Joe Damato wrote: > > > Add functions to support the netdev-genl per queue stats API. > > > > > > ./cli.py --spec netlink/specs/netdev.yaml \ > > > --dump qstats-get --json '{"scope": "queue"}' > > > > > > ...snip > > > > > > {'ifindex': 7, > > > 'queue-id': 62, > > > 'queue-type': 'rx', > > > 'rx-alloc-fail': 0, > > > 'rx-bytes': 105965251, > > > 'rx-packets': 179790}, > > > {'ifindex': 7, > > > 'queue-id': 0, > > > 'queue-type': 'tx', > > > 'tx-bytes': 9402665, > > > 'tx-packets': 17551}, > > > > > > ...snip > > > > > > Also tested with the script tools/testing/selftests/drivers/net/stats.py > > > in several scenarios to ensure stats tallying was correct: > > > > > > - on boot (default queue counts) > > > - adjusting queue count up or down (ethtool -L eth0 combined ...) > > > - adding mqprio TCs > > > > > > Signed-off-by: Joe Damato > > > > Tariq, could you take a look? Is it good enough to make 6.10? > > Would be great to have it.. > > Thanks Jakub. > > FYI: I've also sent a v5 of the mlx4 patches which is only a very minor > change from the v4 as suggested by Tariq (see the changelog in that cover > letter). > > I am not trying to "rush" either in, to to speak, but if they both made it > to 6.10 it would be great to have the same support on both drivers in the > same kernel release :) Err, sorry, just going through emails now and saw that net-next was closed just before I sent the v5. My apologies for missing that announcement. Do I need to re-send after net-next re-opens or will it automatically be in the queue for net-next?