From: Sabrina Dubroca <sd@queasysnail.net>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vasiliy Kovalev <kovalev@altlinux.org>,
Guillaume Nault <gnault@redhat.com>,
Simon Horman <horms@kernel.org>,
David Lebrun <david.lebrun@uclouvain.be>
Subject: Re: [PATCHv2 net-next] ipv6: sr: restruct ifdefines
Date: Wed, 29 May 2024 15:41:23 +0200 [thread overview]
Message-ID: <ZlcwggXSO3qUI1vU@hog> (raw)
In-Reply-To: <20240529040908.3472952-1-liuhangbin@gmail.com>
2024-05-29, 12:09:08 +0800, Hangbin Liu wrote:
> There are too many ifdef in IPv6 segment routing code that may cause logic
> problems. like commit 160e9d275218 ("ipv6: sr: fix invalid unregister error
> path"). To avoid this, the init functions are redefined for both cases. The
> code could be more clear after all fidefs are removed.
>
> Suggested-by: Simon Horman <horms@kernel.org>
> Suggested-by: David Ahern <dsahern@kernel.org>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> v2: add a new label to call seg6_iptunnel_exit directly (Sabrina Dubroca)
> add suggested-by tag (Sabrina Dubroca)
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Thanks.
--
Sabrina
next prev parent reply other threads:[~2024-05-29 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 4:09 [PATCHv2 net-next] ipv6: sr: restruct ifdefines Hangbin Liu
2024-05-29 13:41 ` Sabrina Dubroca [this message]
2024-05-29 15:27 ` David Ahern
2024-05-31 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlcwggXSO3qUI1vU@hog \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=david.lebrun@uclouvain.be \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=kovalev@altlinux.org \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).