From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [205.139.111.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2404D179BF for ; Wed, 29 May 2024 13:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.139.111.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716990099; cv=none; b=uDHRXhURtXh2D0AWpJelOZA/HebDpMs+582/TBNyU3lySnrMikDKnEz+VDaGf+FVM7mcssTNahf8qJ45XMYuo92l6vs5FTQASgweJVXuyUQpa8WKrQnRjAPW3Y8tyoVmbS2O0m2hwQ3lCz9rj0GQeLYZmP95cEW/z3uZhgcjVBo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716990099; c=relaxed/simple; bh=3EYMtm2mLyc+/2Ws8ttfhdvLQho4tcZRPXkcEA7b5TU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=TeJBLJcKmQS7pU7Qny307rFVYvd0YunFcJEjNSBQv04+SW6lEWi4Zopoj18ndQKv9faPDaHbQ4gmczSjC8senjU0PRS3K6WUpv4XMHYJO4Fe6RJzEZXml3/bBSt7Z69OGLgKbyuediuc6gZn1a5qVSjA9th1+tLuQ62VkVFiwf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=none smtp.mailfrom=queasysnail.net; arc=none smtp.client-ip=205.139.111.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=queasysnail.net Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-doo1szRqNdq4GVWYaCb5Ng-1; Wed, 29 May 2024 09:41:26 -0400 X-MC-Unique: doo1szRqNdq4GVWYaCb5Ng-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4E7E29AA384; Wed, 29 May 2024 13:41:25 +0000 (UTC) Received: from hog (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22C5B103A3AA; Wed, 29 May 2024 13:41:23 +0000 (UTC) Date: Wed, 29 May 2024 15:41:23 +0200 From: Sabrina Dubroca To: Hangbin Liu Cc: netdev@vger.kernel.org, "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vasiliy Kovalev , Guillaume Nault , Simon Horman , David Lebrun Subject: Re: [PATCHv2 net-next] ipv6: sr: restruct ifdefines Message-ID: References: <20240529040908.3472952-1-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240529040908.3472952-1-liuhangbin@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: queasysnail.net Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable 2024-05-29, 12:09:08 +0800, Hangbin Liu wrote: > There are too many ifdef in IPv6 segment routing code that may cause logi= c > problems. like commit 160e9d275218 ("ipv6: sr: fix invalid unregister err= or > path"). To avoid this, the init functions are redefined for both cases. T= he > code could be more clear after all fidefs are removed. >=20 > Suggested-by: Simon Horman > Suggested-by: David Ahern > Signed-off-by: Hangbin Liu > --- > v2: add a new label to call seg6_iptunnel_exit directly (Sabrina Dubroca) > add suggested-by tag (Sabrina Dubroca) Reviewed-by: Sabrina Dubroca Thanks. --=20 Sabrina