From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: netdev@vger.kernel.org, arinc.unal@arinc9.com,
daniel@makrotopia.org, dqfext@gmail.com, sean.wang@mediatek.com,
andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-mediatek@lists.infradead.org, lorenzo.bianconi83@gmail.com,
nbd@nbd.name
Subject: Re: [PATCH net-next] net: dsa: mt7530: Add debugfs support
Date: Wed, 29 May 2024 17:06:36 +0200 [thread overview]
Message-ID: <ZldEfH1Yy0cH2-OS@lore-desk> (raw)
In-Reply-To: <20240529133130.namqhprxpvhzgkzr@skbuf>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
> Hi Lorenzo,
>
> On Wed, May 29, 2024 at 12:54:37PM +0200, Lorenzo Bianconi wrote:
> > Introduce debugfs support for mt7530 dsa switch.
> > Add the capability to read or write device registers through debugfs:
> >
> > $echo 0x7ffc > regidx
> > $cat regval
> > 0x75300000
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
>
> Apart from the obvious NACK on permitting user space to alter random
> registers outside of the driver's control.
>
> Have you looked at /sys/kernel/debug/regmap/? Or at ethtool --register-dump?
ack, regmap sysfs is fine to dump registers value.
It was just very handy for me to have the capability to change registers
during development (moreover we already have something similar in mt76).
Anyway it is probably something more related to development so I do not
have a strong opinion on it and we discard the patch.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-29 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 10:54 [PATCH net-next] net: dsa: mt7530: Add debugfs support Lorenzo Bianconi
2024-05-29 13:31 ` Vladimir Oltean
2024-05-29 15:06 ` Lorenzo Bianconi [this message]
2024-05-29 14:41 ` Andrew Lunn
2024-05-29 15:08 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZldEfH1Yy0cH2-OS@lore-desk \
--to=lorenzo@kernel.org \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).