From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
nalramli@fastly.com, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Leon Romanovsky <leon@kernel.org>,
"open list:MELLANOX MLX5 core VPI driver"
<linux-rdma@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [RFC net-next v3 0/2] mlx5: Add netdev-genl queue stats
Date: Fri, 31 May 2024 11:30:36 -0700 [thread overview]
Message-ID: <ZloXTJmCJlvh2AGP@LQ3V64L9R2> (raw)
In-Reply-To: <20240530182630.55139604@kernel.org>
On Thu, May 30, 2024 at 06:26:30PM -0700, Jakub Kicinski wrote:
> On Thu, 30 May 2024 18:07:31 -0700 Joe Damato wrote:
> > Unless I am missing something, I think mlx5e_fold_sw_stats64 would
> > need code similar to mlx5e_stats_grp_sw_update_stats_qos and then
> > rtnl would account for htb stats.
>
> Hm, I think you're right. I'm just surprised this could have gone
> unnoticed for so long.
>
> > That said: since it seems the htb numbers are not included right
> > now, I was proposing adding that in later both to rtnl and
> > netdev-genl together, hoping that would keep the proposed
> > simpler/easier to get accepted.
>
> SGTM.
Cool, so based on that it seems like I just need to figure out the
correct implementation for base and tx stats that is correct and
that will be accepted.
Hoping to hear back from them soon as I'd personally love to have
this API available on our systems.
prev parent reply other threads:[~2024-05-31 18:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 3:16 [RFC net-next v3 0/2] mlx5: Add netdev-genl queue stats Joe Damato
2024-05-29 3:16 ` [RFC net-next v3 1/2] net/mlx5e: Add helpers to calculate txq and ch idx Joe Damato
2024-05-30 21:15 ` Jacob Keller
2024-06-01 11:35 ` Simon Horman
2024-06-01 11:39 ` Simon Horman
2024-06-02 19:23 ` Joe Damato
2024-05-29 3:16 ` [RFC net-next v3 2/2] net/mlx5e: Add per queue netdev-genl stats Joe Damato
2024-05-30 21:16 ` Jacob Keller
2024-06-02 9:14 ` Tariq Toukan
2024-06-02 19:22 ` Joe Damato
2024-06-03 11:11 ` Tariq Toukan
2024-06-03 18:11 ` Joe Damato
2024-06-03 19:22 ` Joe Damato
2024-06-03 21:36 ` Tariq Toukan
2024-06-03 21:50 ` Joe Damato
2024-05-31 0:11 ` [RFC net-next v3 0/2] mlx5: Add netdev-genl queue stats Jakub Kicinski
2024-05-31 0:15 ` Joe Damato
2024-05-31 0:39 ` Jakub Kicinski
2024-05-31 0:56 ` Joe Damato
2024-05-31 1:07 ` Joe Damato
2024-05-31 1:26 ` Jakub Kicinski
2024-05-31 18:30 ` Joe Damato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZloXTJmCJlvh2AGP@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nalramli@fastly.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).