From: Guillaume Nault <gnault@redhat.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] vxlan: Pull inner IP header in vxlan_xmit_one().
Date: Wed, 5 Jun 2024 15:37:56 +0200 [thread overview]
Message-ID: <ZmBqNPGtUA22yFQE@debian> (raw)
In-Reply-To: <942dec85581305f7046de9021b69a8dffa29eaf0.camel@redhat.com>
On Tue, Jun 04, 2024 at 12:55:53PM +0200, Paolo Abeni wrote:
> On Wed, 2024-05-29 at 21:01 +0200, Guillaume Nault wrote:
> > Ensure the inner IP header is part of the skb's linear data before
> > setting old_iph. Otherwise, on a fragmented skb, old_iph could point
> > outside of the packet data.
> >
> > Use skb_vlan_inet_prepare() on classical VXLAN devices to accommodate
> > for potential VLANs. Use pskb_inet_may_pull() for VXLAN-GPE as there's
> > no Ethernet header in that case.
>
> AFAICS even vxlan-GPE allows an ethernet header, see tun_p_to_eth_p()
> and:
>
> https://www.ietf.org/archive/id/draft-ietf-nvo3-vxlan-gpe-12.html#name-multi-protocol-support
>
> What I'm missing?
Didn't see that. I'll post a v2.
Thanks.
> Thanks,
>
> Paolo
>
next prev parent reply other threads:[~2024-06-05 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 19:01 [PATCH net] vxlan: Pull inner IP header in vxlan_xmit_one() Guillaume Nault
2024-05-29 19:10 ` Guillaume Nault
2024-06-04 10:55 ` Paolo Abeni
2024-06-05 13:37 ` Guillaume Nault [this message]
2024-06-05 13:49 ` Eric Dumazet
2024-06-05 15:53 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmBqNPGtUA22yFQE@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).