From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87E93157E6F for ; Wed, 5 Jun 2024 20:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.82 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717617762; cv=none; b=Cr7MI95/IQY6vNc5wq/pHpz4VDFusPRkl3HLKgcYwVr1EsKyYAD228VWc0NsqbbaSwTsH2pGo9Iqta3OjPcn45GtmBY7V12KI5QTZMKgPqhxKWuuI0h1Wzh2nkYvjHlyLhvIwia+CZ37+knHHKW7ZNsiUm8RFtbfmgV6CnGIlB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717617762; c=relaxed/simple; bh=/JxVIqbBvUpTaJFuPe7/jHaCJTckHhCxw2OwzeQBwwg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p0tU8zrkfZlYcjksaDgqLePPGy1dGBS4ENp1D+odWyhXIa3PsxrYSyaHig5+TBiLI0jKTlJan9mIKX0nA9MWul2b2hv94T7EepK0+NYnttlpBavB4sEVhDR5cqfyaWopPCK1Sikm86QRYp/ulcqtQKLT3JnBNq1zE7w5vZvxEDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-26-230.elisa-laajakaista.fi [88.113.26.230]) by fgw23.mail.saunalahti.fi (Halon) with ESMTP id 8aaa2179-2376-11ef-80de-005056bdfda7; Wed, 05 Jun 2024 23:02:32 +0300 (EEST) From: Andy Shevchenko Date: Wed, 5 Jun 2024 23:02:30 +0300 To: Herve Codina Cc: Simon Horman , Sai Krishna Gajula , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v2 09/19] irqdomain: Add missing parameter descriptions in docs Message-ID: References: <20240527161450.326615-1-herve.codina@bootlin.com> <20240527161450.326615-10-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240527161450.326615-10-herve.codina@bootlin.com> Mon, May 27, 2024 at 06:14:36PM +0200, Herve Codina kirjoitti: > During compilation, several warning of the following form were raised: > Function parameter or struct member 'x' not described in 'yyy' > > Add the missing function parameter descriptions. ... > /** > * irq_domain_translate_onecell() - Generic translate for direct one cell > * bindings > + * @d: Interrupt domain involved in the translation > + * @fwspec: The firmware interrupt specifier to translate > + * @out_hwirq: Pointer to storage for the hardware interrupt number > + * @out_type: Pointer to storage for the interrupt type (kernel-doc perhaps will complain on something missing here) > */ > int irq_domain_translate_onecell(struct irq_domain *d, You can go further and run scripts/kernel-doc -v -none -Wall ... against this file and fix more issues, like I believe in the above excerpt. -- With Best Regards, Andy Shevchenko