Re: [PATCH 1/8] fwctl: Add basic structure for a class subsystem with a cdev

Randy Dunlap
2024-06-04T16:42:56Z

On 6/3/24 8:53 AM, Jason Gunthorpe wrote:
> diff --git a/drivers/fwctl/Kconfig b/drivers/fwctl/Kconfig
> new file mode 100644
> index 00000000000000..6ceee3347ae642
> --- /dev/null
> +++ b/drivers/fwctl/Kconfig
> @@ -0,0 +1,9 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +menuconfig FWCTL
> + tristate "fwctl device firmware access framework"

Use tab above instead of spaces for indentation, please.

> + help
> + fwctl provides a userspace API for restricted access to communicate
> + with on-device firmware. The communication channel is intended to
> + support a wide range of lockdown compatible device behaviors including
> + manipulating device FLASH, debugging, and other activities that don't
> + fit neatly into an existing subsystem.

--
#Randy