From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jakub Kicinski <kuba@kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
linux-serial@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] ptp: ocp: adjust serial port symlink creation
Date: Sat, 8 Jun 2024 13:10:07 +0300 [thread overview]
Message-ID: <ZmQt_6DaGFXbagSB@surfacebook.localdomain> (raw)
In-Reply-To: <20240510110405.15115-1-vadim.fedorenko@linux.dev>
Fri, May 10, 2024 at 11:04:05AM +0000, Vadim Fedorenko kirjoitti:
> The commit b286f4e87e32 ("serial: core: Move tty and serdev to be children
> of serial core port device") changed the hierarchy of serial port devices
> and device_find_child_by_name cannot find ttyS* devices because they are
> no longer directly attached. Add some logic to restore symlinks creation
> to the driver for OCP TimeCard.
I know that I'm a bit late to the party, but this patch looks like an ugly
hack. The PTP OCP code, in my opinion, needs a lot of love besides the UART
part.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-06-08 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:04 [PATCH v2 net] ptp: ocp: adjust serial port symlink creation Vadim Fedorenko
2024-05-10 11:13 ` Greg Kroah-Hartman
2024-05-22 12:39 ` Vadim Fedorenko
2024-06-04 11:50 ` Greg Kroah-Hartman
2024-06-04 23:53 ` Vadim Fedorenko
2024-06-05 10:05 ` Greg Kroah-Hartman
2024-06-05 10:14 ` Vadim Fedorenko
2024-06-05 10:41 ` Greg Kroah-Hartman
2024-06-05 10:59 ` Vadim Fedorenko
2024-06-05 11:07 ` Greg Kroah-Hartman
2024-06-05 11:25 ` Vadim Fedorenko
2024-06-05 12:22 ` Greg Kroah-Hartman
2024-05-23 15:39 ` Jakub Kicinski
2024-05-23 16:26 ` Greg Kroah-Hartman
2024-05-23 21:06 ` Vadim Fedorenko
2024-05-24 4:06 ` Greg Kroah-Hartman
2024-06-08 10:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmQt_6DaGFXbagSB@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox