From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, horms@kernel.org,
kuba@kernel.org, jiri@resnulli.us, pabeni@redhat.com,
hfdevel@gmx.net, naveenm@marvell.com, jdamato@fastly.com
Subject: Re: [PATCH net-next v9 5/6] net: tn40xx: add mdio bus support
Date: Mon, 10 Jun 2024 11:04:54 +0100 [thread overview]
Message-ID: <ZmbPxgG7vqEyhxEc@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240605232608.65471-6-fujita.tomonori@gmail.com>
On Thu, Jun 06, 2024 at 08:26:07AM +0900, FUJITA Tomonori wrote:
> +static int tn40_mdio_get(struct tn40_priv *priv, u32 *val)
I think this would be better named "tn40_mdio_wait_nonbusy()" because
that seems to be this function's primary purpose.
> +static int tn40_mdio_read_cb(struct mii_bus *mii_bus, int addr, int devnum,
> + int regnum)
> +static int tn40_mdio_write_cb(struct mii_bus *mii_bus, int addr, int devnum,
> + int regnum, u16 val)
I think it would be better to name these both with a _c45 suffix (which
tells us that they're clause 45 accessors) rather than using _cb
(presumably for callback which tells us nothing!)
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-06-10 10:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 23:26 [PATCH net-next v9 0/6] add ethernet driver for Tehuti Networks TN40xx chips FUJITA Tomonori
2024-06-05 23:26 ` [PATCH net-next v9 1/6] net: tn40xx: add pci " FUJITA Tomonori
2024-06-09 11:17 ` Hans-Frieder Vogt
2024-06-09 12:13 ` FUJITA Tomonori
2024-06-05 23:26 ` [PATCH net-next v9 2/6] net: tn40xx: add register defines FUJITA Tomonori
2024-06-05 23:26 ` [PATCH net-next v9 3/6] net: tn40xx: add basic Tx handling FUJITA Tomonori
2024-06-09 11:41 ` Hans-Frieder Vogt
2024-06-10 6:48 ` FUJITA Tomonori
2024-06-10 21:02 ` FUJITA Tomonori
2024-06-05 23:26 ` [PATCH net-next v9 4/6] net: tn40xx: add basic Rx handling FUJITA Tomonori
2024-06-10 9:59 ` Russell King (Oracle)
2024-06-10 12:28 ` FUJITA Tomonori
2024-06-05 23:26 ` [PATCH net-next v9 5/6] net: tn40xx: add mdio bus support FUJITA Tomonori
2024-06-09 11:22 ` Hans-Frieder Vogt
2024-06-10 7:35 ` FUJITA Tomonori
2024-06-10 10:04 ` Russell King (Oracle) [this message]
2024-06-10 12:05 ` FUJITA Tomonori
2024-06-05 23:26 ` [PATCH net-next v9 6/6] net: tn40xx: add phylink support FUJITA Tomonori
2024-06-09 10:34 ` Russell King (Oracle)
2024-06-10 6:10 ` FUJITA Tomonori
2024-06-10 15:42 ` Andrew Lunn
2024-06-10 20:57 ` FUJITA Tomonori
2024-06-09 9:10 ` [PATCH net-next v9 0/6] add ethernet driver for Tehuti Networks TN40xx chips Hans-Frieder Vogt
2024-06-09 10:42 ` Russell King (Oracle)
2024-06-09 12:40 ` Hans-Frieder Vogt
2024-06-09 13:48 ` Russell King (Oracle)
2024-06-09 18:42 ` Hans-Frieder Vogt
[not found] ` <c3f29b80-0085-4dd2-8d78-f2ac2a004474@gmx.net>
2024-06-09 19:12 ` Russell King (Oracle)
2024-06-10 15:37 ` Andrew Lunn
2024-06-09 11:53 ` FUJITA Tomonori
2024-06-11 4:54 ` FUJITA Tomonori
2024-06-11 5:30 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmbPxgG7vqEyhxEc@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=fujita.tomonori@gmail.com \
--cc=hfdevel@gmx.net \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).