From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ADC217624C for ; Tue, 11 Jun 2024 09:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718096981; cv=none; b=a4kn1ZaJlj8yAChaC9fXDvKg27zisGQAD4134X9JhD1Q2EnkCFS9LKLUt6vfWozMS6gjTb7oXkyYUSOQmM4QyGuVwAnLAD9jGZbyz/KA7fM+X9GHHNAaNIBuzwzsHNMqxwwsgfoZkw5MkrGm3nRuxG1f1EwuOv+Glnp5ynlBsjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718096981; c=relaxed/simple; bh=i0S4WNj+dZaz3hdz9rhQaN2ahipED7/FlbM3wn5jydM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LWcB7LMODkVL+dPFmA7OMZ//fPfYbqbX1ltwewSnXM+tnnla4Ldcy3U415UMDRnktLxMXYmBk/fqKGMvu+urOgKtDgDi27pbl+7TIvXRPOYg7Qw3dzafwIKjtCBQ5cB+f65Kzequg/cGYHE8NDJbSXzXiWeJg0d2wLb7TRwg/3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AzEBKa11; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AzEBKa11" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718096979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wJ6NmEpm203v83OTy1RMNtAkzbu+fQMhPGN0G4SJVPY=; b=AzEBKa11QLIpx6MQYNKtDQCAuHbjwK+BNc2qSxs+3DrG45Q4NwKm7F2sMZhlYdq8aJRHS6 ZBpIFSi1i66pTDN0+uvXN3Nw7CGUYk9Vjwli8KG4E77sAopO86hC0+XA95MYzAETTNmFCs 2TyIAzzRRVBT0h1rOqGjwZGluh9QZF4= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-50-TjESSI1IMpu48cL_rC-wXw-1; Tue, 11 Jun 2024 05:09:37 -0400 X-MC-Unique: TjESSI1IMpu48cL_rC-wXw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ebdab94d1dso19993681fa.3 for ; Tue, 11 Jun 2024 02:09:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718096975; x=1718701775; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wJ6NmEpm203v83OTy1RMNtAkzbu+fQMhPGN0G4SJVPY=; b=uyRXyIrl5zefG5WUyox0SIv+vBHUjW17smqRoeot1upv8H4ryIOudkzOOpwfwiSqBl b4J9vX9xuRr1OWytIeIY4n8qS2Jqca0qhP83XkMDo5KcOgJPUF3WiYlgbGXvh8EF0KJ/ adeJKWPIidqMtO1t+ig3ke0ri2IuQP4uQLi7L/pHUHc/8pVYux+snQdrXIl7Cpdazs+z cCivMgTH/G/Wz6f/9bq3dnkcTF0YqXqhrfnAWY3OdLiHWCy/mL9YnEiR8V8SyxWRzPc2 cMDA4dkejKxkPbEg8bwAGg0ugE0b42jAzNOCv+N60Js/TL8TDOCuHDTLt+DzGG8+MQtd fs1w== X-Gm-Message-State: AOJu0YykcvCs6jrLP5dgpuUbWo9R7wgwPK5s8Ip9IyLV+LOFcFl+iIDn R4Un97Ums6VTVSBo0dBAEjFVwYz/6A0HEwzEJVhKyU3ZLfiZ5J+/gdDjzz4YxRZRkeyqQdEsd8e ehjeUFlbTTDZt2EwsCiZsOunedkOfpyBIjVrVcN6dUt/+UjpK67GmzA== X-Received: by 2002:a2e:8004:0:b0:2eb:f5ec:5ad6 with SMTP id 38308e7fff4ca-2ebf5ec6fb4mr4791221fa.0.1718096975462; Tue, 11 Jun 2024 02:09:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7wwWojKAzRVTdY5Y8CDndML4n5EP/ZdMfOeDFja/TJ2/4XahWfKaFctCxnoWRR7nsots0ag== X-Received: by 2002:a2e:8004:0:b0:2eb:f5ec:5ad6 with SMTP id 38308e7fff4ca-2ebf5ec6fb4mr4791061fa.0.1718096974914; Tue, 11 Jun 2024 02:09:34 -0700 (PDT) Received: from localhost (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4218193b0c0sm84032445e9.31.2024.06.11.02.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 02:09:34 -0700 (PDT) Date: Tue, 11 Jun 2024 11:09:33 +0200 From: Davide Caratti To: =?iso-8859-1?Q?Asbj=F8rn_Sloth_T=F8nnesen?= Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Edward Cree , Martin Habets , linux-net-drivers@amd.com, Saeed Mahameed , Leon Romanovsky , Tariq Toukan , linux-rdma@vger.kernel.org, Jesse Brandeburg , Tony Nguyen , intel-wired-lan@lists.osuosl.org, Louis Peens , oss-drivers@corigine.com, linux-kernel@vger.kernel.org, i.maximets@ovn.org Subject: Re: [PATCH net-next 0/5] net: flower: validate encapsulation control flags Message-ID: References: <20240609173358.193178-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240609173358.193178-1-ast@fiberby.net> On Sun, Jun 09, 2024 at 05:33:50PM +0000, Asbjørn Sloth Tønnesen wrote: > Now that all drivers properly rejects unsupported flower control flags > used with FLOW_DISSECTOR_KEY_CONTROL, then time has come to add similar > checks to the drivers supporting FLOW_DISSECTOR_KEY_ENC_CONTROL. > > There are currently just 4 drivers supporting this key, and > 3 of those currently doesn't validate encapsulated control flags. > > Encapsulation control flags may currently be unused, but they should > still be validated by the drivers, so that drivers will properly > reject any new flags when they are introduced. > > This series adds some helper functions, and implements them in all > 4 drivers. > Reviewed-by: Davide Caratti