From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD5C816B75D for ; Wed, 12 Jun 2024 07:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718176960; cv=none; b=L0bvpNZKz4n694Jy04JOl6LJ10m3ERYHODRYJoW7P0Vt3rzDRNjCCXsYbzH2eZun2bKQCi5QFWuj7JH0GG1UUWt9ycRw0UYq2JsbB0B9fO/rvUhI0P4PjLTPuQ5wekKjakmpIVLzihu96DxFQQHsgfZLS6wz2r4RSjDM6OiZVxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718176960; c=relaxed/simple; bh=wkDVA2dK3+U+cA6W49NHBtQ20kiOyRc5qnKumZI2mZ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q6x3OhnRA3v2v8JGMweWjlmyuagwMhGnQE4osin8hslC6v98NXUdZY9pgFKhiZqL89J4Qc0uRAkNGUEYm/bGWz7YOtp8crMd01zviaI3GcPPiOCOGZzkq5QejHStGw3CelFyyKyMdN2ljGlP1t+eyOL6Lajz3WV3N36QHv0RQM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=CSpD9dy4; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="CSpD9dy4" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2ebdfe26217so28818491fa.2 for ; Wed, 12 Jun 2024 00:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1718176956; x=1718781756; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XyAaGEtFFwkdm/QpmeEncAmUxjsc5CcFkHBcrT1qbjY=; b=CSpD9dy4uJ1tvwuowHkLQayntpGdUohvr6xueFj/D1a/5fGv/mkoMcJYpzNmOozN00 u0wDdD+sB/NBft7PmOBci04IC+o6gcrWG7oi37w2mBErAOMEwW/VAGHWq+UPWd3HHcR4 W10/OwPBm7W3VNWvF486v6ekdHcp2UFZhw3G7c65/WCqjtJW6mfCkoz/DcPijtn2qK2F 1uWZwNs0O+qoKc920WjLetOHDH5omM4TLjFLe6P+HiBjizp95UfpOhZjz/6squ8T2/yV G3gu6C0GSyzo5gikg2NISNJOtVB6r9Oi+mt+cRmAPoUl0X2W8n0lO5gaBW37l3ag0Bww zFLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718176956; x=1718781756; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XyAaGEtFFwkdm/QpmeEncAmUxjsc5CcFkHBcrT1qbjY=; b=Z3f6KTSczDW8d5Rnk2a1rKcFeMWKcxPY97MMNMDd3YTOL8vS/N/QYaQSHgbwnBJ6U8 0x1M9sEr6pOMc/upsfZdA6Si9bFGbXZ8pmp3WsEZl7BhLmLURpJHNE/e/2xzc7Lb/CRl cOD8B9DVeGqvU2qANzPv3M20q8p1GW1Cj3A9jzVdBlO4jOHhveUvTvDWOkf+8HEhK3+W 5MqcnLNUPClsxGgjYTBrRE7mJcDroESUy9YopmQ8NngFOKYrp9RI6NFKgoCEhHN3TUDL 0Nbu57mb88pddcbyDJsL9tOOuXj37w4qrD8W9TC+u8wySPEL3GGrEBwgvwk1Q3y1VaNZ lbEQ== X-Forwarded-Encrypted: i=1; AJvYcCXSPoLyzN+H34lb6A3tlAdT5pbr5P3nNY2WKdHNFxgJMJW5QZXew8fcz3vi79vT2AhIbN9bJ/xZPP+8NBJKJZjxOYW/adk6 X-Gm-Message-State: AOJu0YzBBaYzr0rVX3DGZyK2B4hcIvE+eaQplM3cWmeCMz0sILIsgBE2 UCeVhtji9dFg4dphe4GVOQornuCbAm1IauYQYIPq9ZlQQ/gzs2CiSyWq+5p/R8Q= X-Google-Smtp-Source: AGHT+IH7lMBz0iqDSWgr4Qo//hA7IRWAfAG/YjDjdEYPujMcic/KlfaHdqUt7roVwGJmVDixv7uEJw== X-Received: by 2002:a05:651c:8a:b0:2eb:efff:7729 with SMTP id 38308e7fff4ca-2ebfc8ffa4bmr5282021fa.6.1718176955743; Wed, 12 Jun 2024 00:22:35 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f1c958f9fsm9730922f8f.38.2024.06.12.00.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 00:22:35 -0700 (PDT) Date: Wed, 12 Jun 2024 09:22:32 +0200 From: Jiri Pirko To: "Michael S. Tsirkin" Cc: Jakub Kicinski , Cindy Lu , dtatulea@nvidia.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool Message-ID: References: <20240611053239.516996-1-lulu@redhat.com> <20240611185810.14b63d7d@kernel.org> <20240612031356-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240612031356-mutt-send-email-mst@kernel.org> Wed, Jun 12, 2024 at 09:15:44AM CEST, mst@redhat.com wrote: >On Wed, Jun 12, 2024 at 08:29:53AM +0200, Jiri Pirko wrote: >> Wed, Jun 12, 2024 at 03:58:10AM CEST, kuba@kernel.org wrote: >> >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: >> >> Add new UAPI to support the mac address from vdpa tool >> >> Function vdpa_nl_cmd_dev_config_set_doit() will get the >> >> MAC address from the vdpa tool and then set it to the device. >> >> >> >> The usage is: vdpa dev set name vdpa_name mac **:**:**:**:**:** >> > >> >Why don't you use devlink? >> >> Fair question. Why does vdpa-specific uapi even exist? To have >> driver-specific uapi Does not make any sense to me :/ > >I am not sure which uapi do you refer to? The one this patch proposes or >the existing one? Sure, I'm sure pointing out, that devlink should have been the answer instead of vdpa netlink introduction. That ship is sailed, now we have unfortunate api duplication which leads to questions like Jakub's one. That's all :/