From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC8169959 for ; Thu, 13 Jun 2024 07:21:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718263275; cv=none; b=GGyNgyFRjyJ6jt0ELr+328fHOzOYqEFfj45djCktSTrMTm8dXYn+TcSd+WX9ngiNKytO+eo6EEeUZT711qrN4zCFnT7Pc2cTQds79KlFfgpb6aDa+I35oCAU/m/mLDIaBAGHSeWKUiTJ/gUHa+v+guAfUJJVFr9qg00Ylmtm3Wg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718263275; c=relaxed/simple; bh=l80RjXdZw7gxCEOaUJxc6adU9RUoluvmfgHKiXUbHxU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xepgb3oLll2MO766M9d7VvI/6ozOyMqU4ykwYuaQTiGijEiKNWyY249FP9hbJDL60NRp5lVvMReWi+z3aIkDt9gXFcizbwZ8e4kthPpWy6RRkg3vM8RBp1lzPPadem+USfyVeyOpWogWJuTEdGZZXUSRPuWGE0ajoV1VZUvBOKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=bt3BZeXR; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="bt3BZeXR" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-35f2c0b7701so396812f8f.0 for ; Thu, 13 Jun 2024 00:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1718263272; x=1718868072; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nhdTMjtoIXZFugvUtXucLNLZ+wuL3jj/Mf2FujAvEdI=; b=bt3BZeXRRVH0aOKqgTVaSP4slhRVfUfIkCGypAJLxA8h2CAbWbuoVB7L5hkHzFFhW+ LyYJ8+bTXgH/qvbevlwsvRbRn+3B7insaYLbJ9c69g5aL4wx9EsL/Ys19qrML/s653o1 oh5QXUufs4HJdo8n9oHNhqb1F4k4AuVskcwjXbrDkYPyhpF7hh/4agbZnskqlg9hf2nj H2YvhdNI002qCH6r6UGlZGvTRgXpJNAFmJjF83ud6UnfrlpQcdRcI8VPNILMut6JeLMd /pcAJwYz88Plctnic5btNCKqtsmYMVMFuwwMcpgUb0i9P6geXItsTg0MWiw2cIC5o1Af +QtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718263272; x=1718868072; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nhdTMjtoIXZFugvUtXucLNLZ+wuL3jj/Mf2FujAvEdI=; b=GzcVFIGp2ENVNQRv/3fW5+AyS0b2qgONx0uNMm5vo4NtZNsEB3V2+Gs2KXAUAN4lrz ixRZgOtPcJH3h43m6wLrXX+L9q1nh72WrjHwSTDF1ZSLZuCQkUzQwI64aVKONkOYc+Di Tn+fDIpRA55W+VClvImWqGL6JrReft2kxE8MSY0NB9RQiijUBGtVu6nNIKmlK/DQoPP6 71B159hfoZ/+GR5p2uvIFjOt54ePbbUGrwpVCDltZn2yBGhoKP5fCzXYm+OZ/pzySFzw MI8mOPTgrOXhgZpUVUCCUsP8Sz8XfTKVVcLQ2h7tueHgIvQ3AVLXhPjGNjDLvH20DbX6 /O8A== X-Forwarded-Encrypted: i=1; AJvYcCXFTo4sI3cluUdkyChYxOc9PQG+zJyj3tZRDKDwwZc+bkWI+UnyM4Sce3OqVn4lDXYWBQiBhHA0yOzVls5ivUAS18v57Muv X-Gm-Message-State: AOJu0YwdDXOQWlaADSHTwkBM839e+OQvf9qDaDjkIYgnkHE2G58OWv7U TkSWHdNdVCU1RugmoF27VtExb24iVTVw8uM2ry6/CTv/9lWt2ER3QkIAkrRwxtk= X-Google-Smtp-Source: AGHT+IEhPIOPdXqAxFfHuuOD1kWxW9YlJJ2QDiJYUAHkDsdB9olUY85yrXKWxCO/8TkZGGaYlxO5Fg== X-Received: by 2002:a5d:45cc:0:b0:35f:d07:d34 with SMTP id ffacd0b85a97d-360718e5232mr1590625f8f.27.1718263271467; Thu, 13 Jun 2024 00:21:11 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750ad20bsm821833f8f.54.2024.06.13.00.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 00:21:10 -0700 (PDT) Date: Thu, 13 Jun 2024 09:21:07 +0200 From: Jiri Pirko To: "Michael S. Tsirkin" Cc: Jakub Kicinski , Cindy Lu , dtatulea@nvidia.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool Message-ID: References: <20240611053239.516996-1-lulu@redhat.com> <20240611185810.14b63d7d@kernel.org> <20240612031356-mutt-send-email-mst@kernel.org> <20240613024756-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613024756-mutt-send-email-mst@kernel.org> Thu, Jun 13, 2024 at 08:49:25AM CEST, mst@redhat.com wrote: >On Wed, Jun 12, 2024 at 09:22:32AM +0200, Jiri Pirko wrote: >> Wed, Jun 12, 2024 at 09:15:44AM CEST, mst@redhat.com wrote: >> >On Wed, Jun 12, 2024 at 08:29:53AM +0200, Jiri Pirko wrote: >> >> Wed, Jun 12, 2024 at 03:58:10AM CEST, kuba@kernel.org wrote: >> >> >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: >> >> >> Add new UAPI to support the mac address from vdpa tool >> >> >> Function vdpa_nl_cmd_dev_config_set_doit() will get the >> >> >> MAC address from the vdpa tool and then set it to the device. >> >> >> >> >> >> The usage is: vdpa dev set name vdpa_name mac **:**:**:**:**:** >> >> > >> >> >Why don't you use devlink? >> >> >> >> Fair question. Why does vdpa-specific uapi even exist? To have >> >> driver-specific uapi Does not make any sense to me :/ >> > >> >I am not sure which uapi do you refer to? The one this patch proposes or >> >the existing one? >> >> Sure, I'm sure pointing out, that devlink should have been the answer >> instead of vdpa netlink introduction. That ship is sailed, > >> now we have >> unfortunate api duplication which leads to questions like Jakub's one. >> That's all :/ > > > >Yea there's no point to argue now, there were arguments this and that >way. I don't think we currently have a lot >of duplication, do we? True. I think it would be good to establish guidelines for api extensions in this area. > >-- >MST >