From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF2A113D53E for ; Thu, 13 Jun 2024 22:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718316726; cv=none; b=b8uZle87ouLmcE8Igw7Eqj4yAZ+lw60pNGDrH76YtZSiOfqgvxYUjFbmTYRWUcTpLlQrEEpXObzQhB6T7uwBPfuf/PTamFOwDIQyjNiXHBlbkM/cCLnLT6frJWe0NkkIWL+utS94A9uuL5yKpsRO9JBbPD1yPLhKcazcUoNaA9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718316726; c=relaxed/simple; bh=ZbeYYg9Yb+PWLgJcPoeqspm3fTvQiE0OL7WdGxjUaeM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QKciBr8i7I/AfAusG34QfJtgivmojJ9sqv2hFRpB07Ti3N7jaDx83ob1S5aGR1tSf8SSkTQ/bjU+eBGG37fLR6fAZyFo89IC8BYbLdeslw2QObD2Zd9TFf1/7ZMyPkO/MiMFXv3q92QO3SC18PKa4ZAQVvfj2U9LbsduJQJN9sY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=t1ItnqDt; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="t1ItnqDt" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5babfde1c04so701153eaf.2 for ; Thu, 13 Jun 2024 15:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1718316724; x=1718921524; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=T8aaukLJIwFlsN0imklBHYYukOSpHGK2753nAdx6l5c=; b=t1ItnqDtX3GKBE588Bh+j+YNqPMHtjKEkCJh9RHs118IRuc/5Co+Wse6+GylERj+4G BPkVUYX6C8MRFZoY6eRTjNgwecQYGzXJJ+OZKcI38yygOARQXLum+FEbRojDX1H2Be8z OPyOVFfKAx4jwcUyRn68hPvxhorqf9nmw/SuA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718316724; x=1718921524; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T8aaukLJIwFlsN0imklBHYYukOSpHGK2753nAdx6l5c=; b=dOEcD0x9H6TArq+x6TH/+d3ILlJVV9xAvahUXt+xZWHaTWW6Cj92tK1ES6eMq0W+ja bD+c90Cq4l5qJQBWXpNOgPB70NKUkdVRH5pzvT9ggDGsfCqdNQaiFZEzgntzZy4r5qcC +/c5D6XAetUfkGch8A2sltf/lBZGoU5ndM5jVcIgu2Xcs3j3d6M3eW2sYUlq746VdLKO i6yhL9Rj/GZZbkC54zGfyK7sjjcn3G3h3PgdQ8AMEC/tZxLse/olyrNoegAeC/zLWlHv UNO0JRxvu4u0VMp+/NkcAB/Qd82uyyWoVtfIlqleUQUDmtJjuAY2nnMfQuYJ51LKAIrR dXKA== X-Forwarded-Encrypted: i=1; AJvYcCWASrOMScBu5MrvkW4SXjHM2UcDhJrOkH4d6WPVR11LQLeGg3UUXhhSfToKC64uy5O2RKQjpre5bFAVoNW3tTmQdkcWw0VV X-Gm-Message-State: AOJu0YxnLecnG4QWcvELJ5Qd8e4VIqlV/Sq/biqgQqq3ZdoLCPaBKtZe juY11K0pUHf9NXxn8K8SD1HvTMZ89s/huQfkBz/c577+wYzl3vhcYpB0c62RRFs= X-Google-Smtp-Source: AGHT+IGxwqv5ZLM3BKYkdZcKNyZQfMc0l1HwDn/+qM3n2LPEalG1dk/xF9XaxIPEESTy/A2IjbKb2A== X-Received: by 2002:a05:6358:5918:b0:19f:3ee1:d1c1 with SMTP id e5c5f4694b2df-19fc46e0187mr104458255d.31.1718316723942; Thu, 13 Jun 2024 15:12:03 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6fede16a598sm1562424a12.24.2024.06.13.15.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 15:12:03 -0700 (PDT) Date: Thu, 13 Jun 2024 15:12:00 -0700 From: Joe Damato To: Jakub Kicinski Cc: Tariq Toukan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, nalramli@fastly.com, Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , "open list:MELLANOX MLX5 core VPI driver" , Tariq Toukan Subject: Re: [net-next v5 2/2] net/mlx5e: Add per queue netdev-genl stats Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , Tariq Toukan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, nalramli@fastly.com, Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , "open list:MELLANOX MLX5 core VPI driver" , Tariq Toukan References: <20240612200900.246492-1-jdamato@fastly.com> <20240612200900.246492-3-jdamato@fastly.com> <0a38f58a-2b1e-4d78-90e1-eb8539f65306@gmail.com> <20240613145817.32992753@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613145817.32992753@kernel.org> On Thu, Jun 13, 2024 at 02:58:17PM -0700, Jakub Kicinski wrote: > On Thu, 13 Jun 2024 23:25:12 +0300 Tariq Toukan wrote: > > > + for (i = priv->channels.params.num_channels; i < priv->stats_nch; i++) { > > > > IIUC, per the current kernel implementation, the lower parts won't be > > completed in a loop over [0..real_num_rx_queues-1], as that loop is > > conditional, happening only if the queues are active. > > Could you rephrase this? Is priv->channels.params.num_channels > non-zero also when device is closed? I'm just guessing from > the code, TBH, I can't parse your reply :( I don't mean to speak for Tariq (so my apologies Tariq), but I suspect it may not be clear in which cases IFF_UP is checked and in which cases get_base is called. I tried to clear it up in my longer response with examples from code. If you have a moment could you take a look and let me know if I've gotten it wrong in my explanation/walk through?