Re: [PATCH net-next] net: sun3lance: Remove redundant assignment

Jakub Kicinski
2024-06-18T01:00:07Z

On Fri, 14 Jun 2024 10:52:31 -0400 Kamal Heib wrote:
> There is no point in initializing an ndo to NULL, therefore the
> assignment is redundant and can be removed.
>
> Signed-off-by: Kamal Heib <kheib@redhat.com>
> ---
> drivers/net/ethernet/amd/sun3lance.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/sun3lance.c b/drivers/net/ethernet/amd/sun3lance.c
> index 246f34c43765..fe12051d8471 100644
> --- a/drivers/net/ethernet/amd/sun3lance.c
> +++ b/drivers/net/ethernet/amd/sun3lance.c
> @@ -296,7 +296,6 @@ static const struct net_device_ops lance_netdev_ops = {
> .ndo_stop = lance_close,
> .ndo_start_xmit = lance_start_xmit,
> .ndo_set_rx_mode = set_multicast_list,
> - .ndo_set_mac_address = NULL,
> .ndo_validate_addr = eth_validate_addr,
> };
>

We seem to have a lot of these:

$ git grep -E '^[[:space:]]\.[a-z_]*[[:space:]]*= NULL,' -- drivers/net/
| wc -l
287

and we try to discourage folks from sending cleanup patches to
very old device drivers. So, unfortunately, I'd prefer to leave
this code as is.