From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4B5613E03D; Thu, 27 Jun 2024 10:38:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.27.120 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719484732; cv=none; b=CVT6pL9uHsZHIljeQu+fnN0f+id17Pr5277ZOCZwneUXZZhtuuOKsRoloyaIEaY9GpKrqiLeuETGzShWJZBTuLxBz4lJz58shKzGe5foIsRrpw9Bjkt4QQNShNDKx77mj4LIjXMbWm14lGv/XmAhCkfhgyHy/IyvKDipDX/AwSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719484732; c=relaxed/simple; bh=Jud3pBjzYaVVTkMozMUQg71iRiqsWiENkrf528dOppA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HeYL6n6xO65tlKeOxzYVqPtwuHo3zny6TmvO2Y96owLAla36tJIZMCTSeDqPsLTnmxEAMEpHXE8gpO8A5IzlDCFd17tKbX/zeTAX1AOqkl5viaC/NF3rEDjlEhhE7gdW5MT+1Ew9nnDBo6SePvWk9dsT2xkFq/oFfUqF4y/PJh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=gnumonks.org; arc=none smtp.client-ip=213.95.27.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gnumonks.org Received: from [78.30.37.63] (port=34254 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sMmWa-009WgY-Jp; Thu, 27 Jun 2024 12:38:46 +0200 Date: Thu, 27 Jun 2024 12:38:43 +0200 From: Pablo Neira Ayuso To: Paolo Abeni Cc: Linus Torvalds , netfilter-devel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, edumazet@google.com, fw@strlen.de Subject: Re: [PATCH net 2/2] netfilter: nf_tables: fully validate NFT_DATA_VALUE on store to data registers Message-ID: References: <20240626233845.151197-1-pablo@netfilter.org> <20240626233845.151197-3-pablo@netfilter.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Score: -1.9 (-) On Thu, Jun 27, 2024 at 12:29:20PM +0200, Pablo Neira Ayuso wrote: > On Thu, Jun 27, 2024 at 12:26:49PM +0200, Paolo Abeni wrote: > > Hi, > > On Thu, 2024-06-27 at 03:13 +0200, Pablo Neira Ayuso wrote: > > > On Wed, Jun 26, 2024 at 05:51:13PM -0700, Linus Torvalds wrote: > > > > On Wed, 26 Jun 2024 at 16:38, Pablo Neira Ayuso wrote: > > > > > > > > > > Reported-by: Linus Torvalds > > > > > > > > Oh, I was only the messenger boy, not the actual reporter. > > > > > > > > I think reporting credit should probably go to HexRabbit Chen > > > > > > > > > > I would not have really know if you don't tell me TBH, else it would > > > have taken even longer for me to react and fix it. Because they did > > > not really contact me to report this issue this time. > > > > > > But if you insist, I will do so. > > > > I'm sorry for the late reply. > > > > I guess the most fair option would be adding both tags. "Fair option" maybe sounds too strong in this case, that email which reported this pointer leak to userspace through ZDI did not even report this issue to us in first place... Linus was so kind to attract my attention on this, I appreciate he contacted me. Could you append this text to the pull request message: Linus found this pointer leak to userspace via zdi-disclosures@ and forwarded the notice to Netfilter maintainers, he appears as reporter because whoever found this issue never approached Netfilter maintainers neither via security@ nor in private. If still not acceptable, I am fine to send a new PR and miss this round of fixes. Thanks Paolo. > > With a repost, this will not make it into todays PR, I hope it's not a > > problem. > > It is a addressing a public issue, the reporter decided to follow a > different channel other than security@ for whatever reason. > > I'd prefer if you can take it in this round.