From: Sabrina Dubroca <sd@queasysnail.net>
To: Antonio Quartulli <antonio@openvpn.net>
Cc: netdev@vger.kernel.org, kuba@kernel.org, ryazanov.s.a@gmail.com,
pabeni@redhat.com, edumazet@google.com, andrew@lunn.ch
Subject: Re: [PATCH net-next v5 05/25] ovpn: add basic interface creation/destruction/management routines
Date: Sat, 29 Jun 2024 00:11:32 +0200 [thread overview]
Message-ID: <Zn81FBrUNUMC6VvM@hog> (raw)
In-Reply-To: <20240627130843.21042-6-antonio@openvpn.net>
2024-06-27, 15:08:23 +0200, Antonio Quartulli wrote:
> +static void ovpn_setup(struct net_device *dev)
> +{
> + /* compute the overhead considering AEAD encryption */
> + const int overhead = sizeof(u32) + NONCE_WIRE_SIZE + 16 +
Is that 16 equal to OVPN_MAX_PADDING? Or some other constant that
would help figure out the details of that overhead?
> + sizeof(struct udphdr) +
> + max(sizeof(struct ipv6hdr), sizeof(struct iphdr));
> +
> + netdev_features_t feat = NETIF_F_SG | NETIF_F_LLTX |
[...]
> + dev->features |= feat;
> + dev->hw_features |= feat;
I'm not sure we want NETIF_F_LLTX to be part of hw_features, I think
it's more of a property of the device than something we want to let
users toggle. AFAICT no other virtual driver does that.
--
Sabrina
next prev parent reply other threads:[~2024-06-28 22:12 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 13:08 [PATCH net-next v5 00/25] Introducing OpenVPN Data Channel Offload Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 01/25] netlink: add NLA_POLICY_MAX_LEN macro Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 02/25] rtnetlink: don't crash on unregister if no dellink exists Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 03/25] net: introduce OpenVPN Data Channel Offload (ovpn) Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 04/25] ovpn: add basic netlink support Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 05/25] ovpn: add basic interface creation/destruction/management routines Antonio Quartulli
2024-06-28 22:11 ` Sabrina Dubroca [this message]
2024-07-01 8:48 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 06/25] ovpn: implement interface creation/destruction via netlink Antonio Quartulli
2024-07-03 21:27 ` Sabrina Dubroca
2024-07-03 21:44 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 07/25] ovpn: keep carrier always on Antonio Quartulli
2024-06-27 16:25 ` Andrew Lunn
2024-06-27 13:08 ` [PATCH net-next v5 08/25] ovpn: introduce the ovpn_peer object Antonio Quartulli
2024-07-03 21:37 ` Sabrina Dubroca
2024-07-03 22:16 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 09/25] ovpn: introduce the ovpn_socket object Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 10/25] ovpn: implement basic TX path (UDP) Antonio Quartulli
2024-07-18 10:07 ` Sabrina Dubroca
2024-07-18 10:16 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 11/25] ovpn: implement basic RX " Antonio Quartulli
2024-07-08 16:11 ` Sabrina Dubroca
2024-07-08 22:09 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 12/25] ovpn: implement packet processing Antonio Quartulli
2024-07-09 8:51 ` Sabrina Dubroca
2024-07-10 11:38 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 13/25] ovpn: store tunnel and transport statistics Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 14/25] ovpn: implement TCP transport Antonio Quartulli
2024-07-15 9:59 ` Sabrina Dubroca
2024-07-18 10:13 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 15/25] ovpn: implement multi-peer support Antonio Quartulli
2024-07-15 10:40 ` Sabrina Dubroca
2024-07-17 14:05 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 16/25] ovpn: implement peer lookup logic Antonio Quartulli
2024-07-15 13:11 ` Sabrina Dubroca
2024-07-17 14:07 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 17/25] ovpn: implement keepalive mechanism Antonio Quartulli
2024-07-15 14:44 ` Sabrina Dubroca
2024-07-17 15:30 ` Antonio Quartulli
2024-07-17 16:19 ` Eyal Birger
2024-07-18 8:20 ` Antonio Quartulli
2024-07-17 20:40 ` Sabrina Dubroca
2024-07-18 8:22 ` Antonio Quartulli
2024-07-18 2:01 ` Andrew Lunn
2024-07-18 7:46 ` Antonio Quartulli
2024-07-19 3:31 ` Andrew Lunn
2024-07-19 8:59 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 18/25] ovpn: add support for updating local UDP endpoint Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 19/25] ovpn: add support for peer floating Antonio Quartulli
2024-07-17 17:15 ` Sabrina Dubroca
2024-07-18 9:37 ` Antonio Quartulli
2024-07-18 11:12 ` Sabrina Dubroca
2024-07-18 13:21 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 20/25] ovpn: implement peer add/dump/delete via netlink Antonio Quartulli
2024-07-16 13:41 ` Sabrina Dubroca
2024-07-17 14:04 ` Antonio Quartulli
2024-07-17 15:37 ` Sabrina Dubroca
2024-06-27 13:08 ` [PATCH net-next v5 21/25] ovpn: implement key add/del/swap " Antonio Quartulli
2024-07-17 17:17 ` Sabrina Dubroca
2024-07-18 8:29 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 22/25] ovpn: kill key and notify userspace in case of IV exhaustion Antonio Quartulli
2024-07-17 10:42 ` Sabrina Dubroca
2024-07-17 11:03 ` Antonio Quartulli
2024-07-17 13:26 ` Sabrina Dubroca
2024-07-17 13:38 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 23/25] ovpn: notify userspace when a peer is deleted Antonio Quartulli
2024-07-17 10:54 ` Sabrina Dubroca
2024-07-17 11:16 ` Antonio Quartulli
2024-06-27 13:08 ` [PATCH net-next v5 24/25] ovpn: add basic ethtool support Antonio Quartulli
2024-06-27 16:25 ` Andrew Lunn
2024-06-27 13:08 ` [PATCH net-next v5 25/25] testing/selftest: add test tool and scripts for ovpn module Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn81FBrUNUMC6VvM@hog \
--to=sd@queasysnail.net \
--cc=andrew@lunn.ch \
--cc=antonio@openvpn.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).