From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 833C9192B82 for ; Mon, 17 Jun 2024 09:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718616644; cv=none; b=hzXrLXpnvzMEa+0x0hUQkP00Ui5JpIAQ+JjMmB3eeptnOc/9UL5CnKpRx1TFYBC/ivFp+7hSY8VrrLWG7QcVpiKfsin/0bsG7iG8fKN+3GHQ31IC2XhoIyw/5B+iFb5wYk+f5VIc1A3er/3ktCw40ayDN9G13WLiADdwWrlRR6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718616644; c=relaxed/simple; bh=QLxX4Rpj7zYvuJpj/kPpfbxaCfiDItCMeqMDeGVl4V4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f6uC5nAicLt1yYxLXs7Ya+4lP+sEoJ5foBrnpiAB7dGlVr5EZ7OgwS+JzdUUceqhs6IvZ37Ovc100O3OjhHE/Hf2CwsE1kAiztgCL4szs3UBYz7t+LhvDyogMpaFqeJK02eUPyu7iiBdujHnY0Nf+JnJ9B/u6oBP1AcKuoRhiFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=qo76LF7n; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="qo76LF7n" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52cc129c78fso108898e87.2 for ; Mon, 17 Jun 2024 02:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1718616640; x=1719221440; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8QLktAGNTjUFJei+a7Yp7B+dYTOmyOgcx1VIYD5aK+o=; b=qo76LF7nDvXgRAknReGqBrbCSsy7mQj892E5Ldwgb1jViJ5GpGtMSF91p+xeokXjwQ nUJFNfwie78O0GZpKp9lTtulyV1LdSSSwrQ93GkK48ygSEKc/QpDEUj83p4PbebIi3ja kqEFGiqv+WnxokgYDrUsOBchxzNVNXM83JuFaeuJj9Wh9RyK4PvOWF5FXo8sOuFhXfWS ldx8RAHmWoxsunsyaz3AP7DAFWcCbetybYilfDIIOfdsXkx+0buXXHSGt6gjaJNArtlw qm7a0OYoX19W9B9fJSM8qImg34KPa3aO09D3cuitsD0xkmDfoHBi92EktDsPWAVcnYvO Ynlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718616640; x=1719221440; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8QLktAGNTjUFJei+a7Yp7B+dYTOmyOgcx1VIYD5aK+o=; b=fnB92ol7PSLPjUZJO7D5z5+tWoT1GIo8pnGYrTrkvjSezgyQsF3oVGWd2Be4JRx/uQ X+Muox1Fx0hMva4Drp/5N54DOj2GAK9SyEpdW27CRTPyqIlqes+EhyGMaAEtr6tLLHHK 1ECmSrSUNnDE1iPtpyEG7zz1idiTDrEK75G3nrWjquTSOIePNSlG0ldJFKFi7JzD66Jl Kcb7Ge1bBsSYaXTdHzafekT447FVexNQvD76rsHUrBmCQuijxUWDTbAhPGJVFfFgI0AS 5ulMJ9QK7yS1HFdkRlO9qhY0lCIGeGZ0+7WEDO05sJgkqlGzbyie4B+HNDnmevG8J+9M ZsHQ== X-Forwarded-Encrypted: i=1; AJvYcCUcrvw2gOXOJasdBO5t78XuCfbixkP82vbcLmnEiQnb2uf9s0niQ927Jj0jR6P7ge554DbmrTPomREi8qXxtnfRgYEGWnWJ X-Gm-Message-State: AOJu0YxylyqbmVrk+8X97E7X+52hw2HfpdOi7j2+br19INgx6OMAw5X3 Uty4UikvNdPbCt5/8P4HS0AcnDBpskI7fHkMrC4WN6qgD2ESnPRi+BqY9XsP17A= X-Google-Smtp-Source: AGHT+IFeQQ3VLHyWUDWMF94tKcMqEnxKjztlgo/DGQL+ULZYyDevfiUpxD8t+PLZ6eWIpx+EZWjgJQ== X-Received: by 2002:a19:385b:0:b0:52c:9846:3b8c with SMTP id 2adb3069b0e04-52ca6e6c7ffmr5359133e87.41.1718616640555; Mon, 17 Jun 2024 02:30:40 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422874e71dcsm188650685e9.44.2024.06.17.02.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 02:30:39 -0700 (PDT) Date: Mon, 17 Jun 2024 11:30:36 +0200 From: Jiri Pirko To: Jason Wang Cc: "Michael S. Tsirkin" , Jason Xing , Heng Qi , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xuanzhuo@linux.alibaba.com, virtualization@lists.linux.dev, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, netdev@vger.kernel.org Subject: Re: [patch net-next] virtio_net: add support for Byte Queue Limits Message-ID: References: <20240607062231-mutt-send-email-mst@kernel.org> <20240610101346-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Mon, Jun 17, 2024 at 03:44:55AM CEST, jasowang@redhat.com wrote: >On Mon, Jun 10, 2024 at 10:19 PM Michael S. Tsirkin wrote: >> >> On Fri, Jun 07, 2024 at 01:30:34PM +0200, Jiri Pirko wrote: >> > Fri, Jun 07, 2024 at 12:23:37PM CEST, mst@redhat.com wrote: >> > >On Fri, Jun 07, 2024 at 11:57:37AM +0200, Jiri Pirko wrote: >> > >> >True. Personally, I would like to just drop orphan mode. But I'm not >> > >> >sure others are happy with this. >> > >> >> > >> How about to do it other way around. I will take a stab at sending patch >> > >> removing it. If anyone is against and has solid data to prove orphan >> > >> mode is needed, let them provide those. >> > > >> > >Break it with no warning and see if anyone complains? >> > >> > This is now what I suggested at all. >> > >> > >No, this is not how we handle userspace compatibility, normally. >> > >> > Sure. >> > >> > Again: >> > >> > I would send orphan removal patch containing: >> > 1) no module options removal. Warn if someone sets it up >> > 2) module option to disable napi is ignored >> > 3) orphan mode is removed from code >> > >> > There is no breakage. Only, hypotetically performance downgrade in some >> > hypotetical usecase nobody knows of. >> >> Performance is why people use virtio. It's as much a breakage as any >> other bug. The main difference is, with other types of breakage, they >> are typically binary and we can not tolerate them at all. A tiny, >> negligeable performance regression might be tolarable if it brings >> other benefits. I very much doubt avoiding interrupts is >> negligeable though. And making code simpler isn't a big benefit, >> users do not care. > >It's not just making code simpler. As discussed in the past, it also >fixes real bugs. > >> >> > My point was, if someone presents >> > solid data to prove orphan is needed during the patch review, let's toss >> > out the patch. >> > >> > Makes sense? >> >> It's not hypothetical - if anything, it's hypothetical that performance >> does not regress. And we just got a report from users that see a >> regression without. So, not really. > >Probably, but do we need to define a bar here? Looking at git history, >we didn't ask a full benchmark for a lot of commits that may touch Moreover, there is no "benchmark" to run anyway, is it? >performance. > >Thanks > >> >> > >> > > >> > >-- >> > >MST >> > > >> >