From: Kamal Heib <kheib@redhat.com>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 3/3] net/mlx4_en: Use ethtool_puts/sprintf to fill stats strings
Date: Mon, 17 Jun 2024 13:20:25 -0400 [thread overview]
Message-ID: <ZnBwWS-j3ZyGkXht@fedora-x1> (raw)
In-Reply-To: <0de75730-5591-42db-911a-abcc24473345@gmail.com>
On Mon, Jun 17, 2024 at 08:06:40AM +0300, Tariq Toukan wrote:
>
>
> On 15/06/2024 4:37, Jakub Kicinski wrote:
> > On Thu, 13 Jun 2024 14:43:33 -0400 Kamal Heib wrote:
> > > Use the ethtool_puts/ethtool_sprintf helper to print the stats strings
> > > into the ethtool strings interface.
> > >
> > > Signed-off-by: Kamal Heib <kheib@redhat.com>
> >
> > minor build issue with this one:
> >
> > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:453:6: warning: unused variable 'index' [-Wunused-variable]
> > 453 | int index = 0;
> > | ^~~~~
> >
> > otherwise LGTM!
>
> Hi Kamal, thanks for your series.
> Please fix and respin.
>
Hello,
Sorry about that.
I'll fix it and post v2 shortly.
Thanks,
Kamal
prev parent reply other threads:[~2024-06-17 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 18:43 [PATCH net-next 0/3] net/mlx4_en: Use ethtool_puts/sprintf Kamal Heib
2024-06-13 18:43 ` [PATCH net-next 1/3] net/mlx4_en: Use ethtool_puts to fill priv flags strings Kamal Heib
2024-06-13 18:43 ` [PATCH net-next 2/3] net/mlx4_en: Use ethtool_puts to fill selftest strings Kamal Heib
2024-06-13 18:43 ` [PATCH net-next 3/3] net/mlx4_en: Use ethtool_puts/sprintf to fill stats strings Kamal Heib
2024-06-15 1:37 ` Jakub Kicinski
2024-06-17 5:06 ` Tariq Toukan
2024-06-17 17:20 ` Kamal Heib [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnBwWS-j3ZyGkXht@fedora-x1 \
--to=kheib@redhat.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox